You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/29 16:25:44 UTC
[GitHub] [arrow] wesm opened a new pull request #7302: ARROW-8978: [C++][CI] Fix valgrind warnings in cpp-conda-valgrind nightly build
wesm opened a new pull request #7302:
URL: https://github.com/apache/arrow/pull/7302
There are benign warnings in the cpp-conda-valgrind build due to accessing uninitialized trailing bits in validity bitmaps. Fixing the warnings without relying on compiler definitions is more complex than it seems (assuming you don't want to always memset the bitmap to all 0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7302: ARROW-8978: [C++][CI] Fix valgrind warnings in cpp-conda-valgrind nightly build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7302:
URL: https://github.com/apache/arrow/pull/7302#issuecomment-636066997
https://issues.apache.org/jira/browse/ARROW-8978
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7302: ARROW-8978: [C++][CI] Fix valgrind warnings in cpp-conda-valgrind nightly build
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7302:
URL: https://github.com/apache/arrow/pull/7302#issuecomment-636216700
Oops thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7302: ARROW-8978: [C++][CI] Fix valgrind warnings in cpp-conda-valgrind nightly build
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7302:
URL: https://github.com/apache/arrow/pull/7302#issuecomment-636064330
@github-actions crossbow submit test-conda-cpp-valgrind
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fsaintjacques commented on a change in pull request #7302: ARROW-8978: [C++][CI] Fix valgrind warnings in cpp-conda-valgrind nightly build
Posted by GitBox <gi...@apache.org>.
fsaintjacques commented on a change in pull request #7302:
URL: https://github.com/apache/arrow/pull/7302#discussion_r432645169
##########
File path: cpp/src/arrow/compute/util_internal.h
##########
@@ -0,0 +1,35 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "arrow/buffer.h"
+
+namespace arrow {
+namespace compute {
+namespace internal {
+
+/// \brief Set data at byte offset in buffer to 0. To help with valgrind issues
+static inline void ZeroByte(Buffer* buffer, int64_t byte_index) {
Review comment:
Fails to [compile](https://github.com/apache/arrow/pull/7302/checks?check_run_id=721039111#step:7:455) on MSVC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #7302: ARROW-8978: [C++][CI] Fix valgrind warnings in cpp-conda-valgrind nightly build
Posted by GitBox <gi...@apache.org>.
kou closed pull request #7302:
URL: https://github.com/apache/arrow/pull/7302
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7302: ARROW-8978: [C++][CI] Fix valgrind warnings in cpp-conda-valgrind nightly build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7302:
URL: https://github.com/apache/arrow/pull/7302#issuecomment-636064999
Revision: 65d20c30b8da334ef9088d6646e1e516670e1cb2
Submitted crossbow builds: [ursa-labs/crossbow @ actions-270](https://github.com/ursa-labs/crossbow/branches/all?query=actions-270)
|Task|Status|
|----|------|
|test-conda-cpp-valgrind|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-270-github-test-conda-cpp-valgrind)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org