[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: Use Builder Pattern with Solr Clients

[GitBox <gi...@apache.org>]

epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1038648987


##########
solr/core/src/test/org/apache/solr/search/TestSmileRequest.java:
##########
@@ -91,7 +90,6 @@ public void assertJQ(SolrClient client, SolrParams args, String... tests)
   // adding this to core adds the dependency on a few extra jars to our distribution.
   // So this is not added there
   public static class SmileResponseParser extends BinaryResponseParser {
-    public static final SmileResponseParser inst = new SmileResponseParser();

Review Comment:
   i liked how `query.setResponseParser(new SmileResponseParser());` looked better, everywhere else we create a new parser....
   I wonder if this should be called "FakeSmileResponseParser" so you don't think it's real...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org