You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/14 06:56:37 UTC
[GitHub] [apisix] spacewander opened a new pull request #6605: feat: add delayed_body_filter phase
spacewander opened a new pull request #6605:
URL: https://github.com/apache/apisix/pull/6605
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Fix https://github.com/apache/apisix/issues/6601
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6605: feat: add delayed_body_filter phase
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6605:
URL: https://github.com/apache/apisix/pull/6605#issuecomment-1067468727
Doesn't this PR modify some tracing plugins to run `delayed_body_filter` phase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6605: feat: add delayed_body_filter phase
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6605:
URL: https://github.com/apache/apisix/pull/6605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #6605: feat: add delayed_body_filter phase
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #6605:
URL: https://github.com/apache/apisix/pull/6605#issuecomment-1067470808
> Doesn't this PR modify some tracing plugins to run `delayed_body_filter` phase?
Yes. But if I do it, this PR will be too big (almost 300 lines).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6605: feat: add delayed_body_filter phase
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6605:
URL: https://github.com/apache/apisix/pull/6605#issuecomment-1067488926
> > Doesn't this PR modify some tracing plugins to run `delayed_body_filter` phase?
>
> Yes. But if I do it, this PR will be too big (almost 300 lines).
got
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org