You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by abashev <gi...@git.apache.org> on 2014/04/06 15:46:57 UTC
[GitHub] thrift pull request: Fix TExtensibleServlet to be able to add cust...
GitHub user abashev opened a pull request:
https://github.com/apache/thrift/pull/95
Fix TExtensibleServlet to be able to add custom headers at init() stage.
Right now with initialization of customHeaders property at init(ServletContext) is not possible to add custom headers at own init() stage. This small patch will fix it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/abashev/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/95.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #95
----
commit e196750120c6036f09aa86216e1932925908d8b7
Author: Alexey Abashev <al...@abashev.ru>
Date: 2014-04-06T13:43:39Z
Fix TExtensibleServlet to be able to add custom headers at init() stage.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix TExtensibleServlet to be able to add cust...
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/95#issuecomment-93615826
Thanks for your patch @abashev, in order for us to accept a pull request we need to have a jira ticket associated with it. Please see our contributing guide at http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix TExtensibleServlet to be able to add cust...
Posted by hcorg <gi...@git.apache.org>.
Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/95#issuecomment-57633997
Please create issue in Jira and paste link in comment here.
http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix TExtensibleServlet to be able to add cust...
Posted by abashev <gi...@git.apache.org>.
Github user abashev commented on the pull request:
https://github.com/apache/thrift/pull/95#issuecomment-44843651
Do I need any actions on last message? As I can see travis is fine with this build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix TExtensibleServlet to be able to add cust...
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/95
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---