You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Mike Percy (Created) (JIRA)" <ji...@apache.org> on 2012/03/22 22:40:22 UTC
[jira] [Created] (FLUME-1047) Client SDK has dependency on apache
commons
Client SDK has dependency on apache commons
-------------------------------------------
Key: FLUME-1047
URL: https://issues.apache.org/jira/browse/FLUME-1047
Project: Flume
Issue Type: Bug
Reporter: Mike Percy
A patch to fix toString of SimpleEvent ended up introducing a dependency on apache commons into the client SDK. Between the time the initial patch was submitted and when it was committed the SimpleEvent class was factored into the client SDK.
Proposal is to remove toString from SimpleEvent and add this HexDump functionality as a utility method in the core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1047) Client SDK has dependency on apache
commons
Posted by "Mike Percy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1047:
------------------------------
Assignee: Mike Percy
Status: Patch Available (was: Open)
> Client SDK has dependency on apache commons
> -------------------------------------------
>
> Key: FLUME-1047
> URL: https://issues.apache.org/jira/browse/FLUME-1047
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Attachments: FLUME-1047-4.patch
>
>
> A patch to fix toString of SimpleEvent ended up introducing a dependency on apache commons into the client SDK. Between the time the initial patch was submitted and when it was committed the SimpleEvent class was factored into the client SDK.
> Proposal is to remove toString from SimpleEvent and add this HexDump functionality as a utility method in the core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1047) Client SDK has dependency on apache
commons
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-1047:
--------------------------------
Resolution: Fixed
Fix Version/s: v1.2.0
Status: Resolved (was: Patch Available)
Committed in 1305718.
> Client SDK has dependency on apache commons
> -------------------------------------------
>
> Key: FLUME-1047
> URL: https://issues.apache.org/jira/browse/FLUME-1047
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1047-4.patch
>
>
> A patch to fix toString of SimpleEvent ended up introducing a dependency on apache commons into the client SDK. Between the time the initial patch was submitted and when it was committed the SimpleEvent class was factored into the client SDK.
> Proposal is to remove toString from SimpleEvent and add this HexDump functionality as a utility method in the core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1047) Client SDK has dependency on apache
commons
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238883#comment-13238883 ]
jiraposter@reviews.apache.org commented on FLUME-1047:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4488/#review6376
-----------------------------------------------------------
Corrected the review field and attached the patch to the Jira. Thanks Brock!
- Mike
On 2012-03-26 21:46:26, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4488/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-26 21:46:26)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Created a static utility method to do the HexDump that the LoggerSink uses as output for events. This lives in the core so that the SDK no longer has any undeclared dependencies.
bq.
bq.
bq. This addresses bug FLUME-1047.
bq. https://issues.apache.org/jira/browse/FLUME-1047
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/event/EventHelper.java PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java f6f9d33
bq. flume-ng-core/src/test/java/org/apache/flume/event/TestEventHelper.java PRE-CREATION
bq. flume-ng-sdk/src/main/java/org/apache/flume/event/SimpleEvent.java 9099206
bq. flume-ng-sdk/src/test/java/org/apache/flume/event/TestSimpleEvent.java 385cb7e
bq.
bq. Diff: https://reviews.apache.org/r/4488/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. mvn clean package
bq. Unpacked tarball, ran: ./bin/flume-ng node -c conf -f conf/flume-conf.properties.template -n foo
bq. Lots of stuff dumped to stdout
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> Client SDK has dependency on apache commons
> -------------------------------------------
>
> Key: FLUME-1047
> URL: https://issues.apache.org/jira/browse/FLUME-1047
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Attachments: FLUME-1047-4.patch
>
>
> A patch to fix toString of SimpleEvent ended up introducing a dependency on apache commons into the client SDK. Between the time the initial patch was submitted and when it was committed the SimpleEvent class was factored into the client SDK.
> Proposal is to remove toString from SimpleEvent and add this HexDump functionality as a utility method in the core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1047) Client SDK has dependency on apache
commons
Posted by "Mike Percy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1047:
------------------------------
Attachment: FLUME-1047-4.patch
> Client SDK has dependency on apache commons
> -------------------------------------------
>
> Key: FLUME-1047
> URL: https://issues.apache.org/jira/browse/FLUME-1047
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Attachments: FLUME-1047-4.patch
>
>
> A patch to fix toString of SimpleEvent ended up introducing a dependency on apache commons into the client SDK. Between the time the initial patch was submitted and when it was committed the SimpleEvent class was factored into the client SDK.
> Proposal is to remove toString from SimpleEvent and add this HexDump functionality as a utility method in the core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1047) Client SDK has dependency on apache
commons
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239165#comment-13239165 ]
Hudson commented on FLUME-1047:
-------------------------------
Integrated in flume-trunk #147 (See [https://builds.apache.org/job/flume-trunk/147/])
FLUME-1047: Client SDK has dependency on apache commons
(Mike Percy via Brock Noland) (Revision 1305718)
Result = SUCCESS
brock : http://svn.apache.org/viewvc/?view=rev&rev=1305718
Files :
* /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/event/EventHelper.java
* /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java
* /incubator/flume/trunk/flume-ng-core/src/test/java/org/apache/flume/event
* /incubator/flume/trunk/flume-ng-core/src/test/java/org/apache/flume/event/TestEventHelper.java
* /incubator/flume/trunk/flume-ng-sdk/src/main/java/org/apache/flume/event/SimpleEvent.java
* /incubator/flume/trunk/flume-ng-sdk/src/test/java/org/apache/flume/event/TestSimpleEvent.java
> Client SDK has dependency on apache commons
> -------------------------------------------
>
> Key: FLUME-1047
> URL: https://issues.apache.org/jira/browse/FLUME-1047
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1047-4.patch
>
>
> A patch to fix toString of SimpleEvent ended up introducing a dependency on apache commons into the client SDK. Between the time the initial patch was submitted and when it was committed the SimpleEvent class was factored into the client SDK.
> Proposal is to remove toString from SimpleEvent and add this HexDump functionality as a utility method in the core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1047) Client SDK has dependency on apache
commons
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238881#comment-13238881 ]
jiraposter@reviews.apache.org commented on FLUME-1047:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4488/
-----------------------------------------------------------
(Updated 2012-03-26 21:46:26.934475)
Review request for Flume.
Summary
-------
Created a static utility method to do the HexDump that the LoggerSink uses as output for events. This lives in the core so that the SDK no longer has any undeclared dependencies.
This addresses bug FLUME-1047.
https://issues.apache.org/jira/browse/FLUME-1047
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/event/EventHelper.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java f6f9d33
flume-ng-core/src/test/java/org/apache/flume/event/TestEventHelper.java PRE-CREATION
flume-ng-sdk/src/main/java/org/apache/flume/event/SimpleEvent.java 9099206
flume-ng-sdk/src/test/java/org/apache/flume/event/TestSimpleEvent.java 385cb7e
Diff: https://reviews.apache.org/r/4488/diff
Testing
-------
mvn clean package
Unpacked tarball, ran: ./bin/flume-ng node -c conf -f conf/flume-conf.properties.template -n foo
Lots of stuff dumped to stdout
Thanks,
Mike
> Client SDK has dependency on apache commons
> -------------------------------------------
>
> Key: FLUME-1047
> URL: https://issues.apache.org/jira/browse/FLUME-1047
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Attachments: FLUME-1047-4.patch
>
>
> A patch to fix toString of SimpleEvent ended up introducing a dependency on apache commons into the client SDK. Between the time the initial patch was submitted and when it was committed the SimpleEvent class was factored into the client SDK.
> Proposal is to remove toString from SimpleEvent and add this HexDump functionality as a utility method in the core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira