[GitHub] yujiantao commented on a change in pull request #4435: [AIRFLOW-3628] Add smtp_mime_from

[GitBox <gi...@apache.org>]

yujiantao commented on a change in pull request #4435: [AIRFLOW-3628] Add smtp_mime_from
URL: https://github.com/apache/airflow/pull/4435#discussion_r245475489
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -342,7 +342,7 @@ smtp_ssl = False
 # smtp_password = airflow
 smtp_port = 25
 smtp_mail_from = airflow@example.com
-
+smtp_mime_from = airflow
 
 Review comment:
   1. smtp_mail_from must be an email address from where the alert email is going to be sent. if we put smtp_mail_from = airflow, the email sending will fail. 
   2. if we set msg['From'] = smtp_mail_from, the receiver will see the email sender is the value fo smtp_mail_from which is an email address. Sometimes the the email address is shared by multiple services like airflow, monitor, data quality, etc. If one received email messages from all these services, it is impossible to distinguish messages by the email sender field quickly. But if we set an alias for the email sender by setting  smtp_mime_from = airflow and msg['From'] = smtp_mime_from, the receiver will see the email from the alias and it is easy to figure out the email is from airflow or other services.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services