You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/10/09 23:19:17 UTC
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/
-----------------------------------------------------------
(Updated Oct. 9, 2017, 11:19 p.m.)
Review request for mesos, Gilbert Song and Jason Lai.
Changes
-------
Update test with new interface.
Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945
Repository: mesos
Description
-------
Added tests for pruneImages for containerizer and provisioner.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
Diff: https://reviews.apache.org/r/60471/diff/5/
Changes: https://reviews.apache.org/r/60471/diff/4-5/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/#review187484
-----------------------------------------------------------
PASS: Mesos patch 60471 was successfully built and tested.
Reviews applied: `['55334', '55335', '59687', '56721', '56722', '60471']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471
- Mesos Reviewbot Windows
On Oct. 9, 2017, 4:19 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60471/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2017, 4:19 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for pruneImages for containerizer and provisioner.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
> src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
>
>
> Diff: https://reviews.apache.org/r/60471/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/#review188454
-----------------------------------------------------------
FAIL: Mesos tests failed to build.
Reviews applied: `['55334', '55335', '59687', '62997', '56721', '56722', '62853', '60471']`
Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471
Relevant logs:
- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471/logs/mesos-tests-build-cmake-stdout.log):
```
C:\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(75): warning C4267: '=': conversion from 'size_t' to 'unsigned long', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(271): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(333): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(216): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(242): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(274): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master/master.hpp(2059): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\common\protobuf_utils.cpp) [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\files\files.cpp(703): warning C4267: 'argument': conversion from 'size_t' to 'off_t', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master/master.hpp(2059): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\master\master.cpp) [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master\master.cpp(5936): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master\master.cpp(6023): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master\master.cpp(6562): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master\master.cpp(8016): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master\master.cpp(9564): warning C4244: 'return': conversion from '::size_t' to 'double', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master/master.hpp(2059): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\master\quota_handler.cpp) [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master/master.hpp(2059): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\master\weights_handler.cpp) [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master\allocator\sorter\drf\sorter.cpp(589): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data [C:\mesos\src\mesos.vcxproj]
"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) ->
C:\mesos\mesos\src\slave/containerizer/mesos/provisioner/provisioner.hpp(37): fatal error C1083: Cannot open include file: 'process/rwmutex.hpp': No such file or directory (compiling source file C:\mesos\mesos\src\slave\containerizer\mesos\provisioner\provisioner.cpp) [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\slave/containerizer/mesos/provisioner/provisioner.hpp(37): fatal error C1083: Cannot open include file: 'process/rwmutex.hpp': No such file or directory (compiling source file C:\mesos\mesos\src\slave\containerizer\mesos\provisioner\docker\metadata_manager.cpp) [C:\mesos\src\mesos.vcxproj]
228 Warning(s)
2 Error(s)
Time Elapsed 00:14:48.48
```
- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471/logs/mesos-tests-CMakeOutput.log):
```
Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_4c7e7.dir\Debug\cmTC_4c7e7.tlog\".
InitializeBuildStatus:
Creating "cmTC_4c7e7.dir\Debug\cmTC_4c7e7.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_4c7e7.dir\Debug\" /Fd"cmTC_4c7e7.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_4c7e7.dir\Debug\" /Fd"cmTC_4c7e7.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_4c7e7.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_4c7e7.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_4c7e7.lib" /MACHINE:X64 /machine:x64 cmTC_4c7e7.dir\Debug\src.obj
cmTC_4c7e7.vcxproj -> C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_4c7e7.exe
cmTC_4c7e7.vcxproj -> C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_4c7e7.pdb (Full PDB)
FinalizeBuildStatus:
Deleting file "cmTC_4c7e7.dir\Debug\cmTC_4c7e7.tlog\unsuccessfulbuild".
Touching "cmTC_4c7e7.dir\Debug\cmTC_4c7e7.tlog\cmTC_4c7e7.lastbuildstate".
Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_4c7e7.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.75
Source file was:
int main() { return 0; }
```
- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471/logs/mesos-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_fd650.dir\Debug\".
Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_fd650.dir\Debug\cmTC_fd650.tlog\".
InitializeBuildStatus:
Creating "cmTC_fd650.dir\Debug\cmTC_fd650.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_fd650.dir\Debug\" /Fd"cmTC_fd650.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_fd650.dir\Debug\" /Fd"cmTC_fd650.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_fd650.vcxproj]
Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_fd650.vcxproj" (default targets) -- FAILED.
Build FAILED.
"C:\mesos\CMakeFiles\CMakeTmp\cmTC_fd650.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_fd650.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.13
```
- Mesos Reviewbot Windows
On Oct. 17, 2017, 5:06 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60471/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 5:06 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for pruneImages for containerizer and provisioner.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
> src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
>
>
> Diff: https://reviews.apache.org/r/60471/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/#review188372
-----------------------------------------------------------
FAIL: Mesos tests failed to build.
Reviews applied: `['55334', '55335', '59687', '62997', '56721', '56722', '62853', '60471']`
Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471
Relevant logs:
- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471/logs/mesos-tests-build-cmake-stdout.log):
```
C:\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(75): warning C4267: '=': conversion from 'size_t' to 'unsigned long', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(271): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(333): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(216): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(242): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(274): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master/master.hpp(2059): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\common\protobuf_utils.cpp) [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\files\files.cpp(703): warning C4267: 'argument': conversion from 'size_t' to 'off_t', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master/master.hpp(2059): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\master\master.cpp) [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master\master.cpp(5936): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master\master.cpp(6023): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master\master.cpp(6562): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master\master.cpp(8016): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master\master.cpp(9564): warning C4244: 'return': conversion from '::size_t' to 'double', possible loss of data [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master/master.hpp(2059): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\master\quota_handler.cpp) [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master/master.hpp(2059): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\master\weights_handler.cpp) [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\master\allocator\sorter\drf\sorter.cpp(589): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data [C:\mesos\src\mesos.vcxproj]
"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) ->
C:\mesos\mesos\src\slave/containerizer/mesos/provisioner/provisioner.hpp(37): fatal error C1083: Cannot open include file: 'process/rwmutex.hpp': No such file or directory (compiling source file C:\mesos\mesos\src\slave\containerizer\mesos\provisioner\provisioner.cpp) [C:\mesos\src\mesos.vcxproj]
C:\mesos\mesos\src\slave/containerizer/mesos/provisioner/provisioner.hpp(37): fatal error C1083: Cannot open include file: 'process/rwmutex.hpp': No such file or directory (compiling source file C:\mesos\mesos\src\slave\containerizer\mesos\provisioner\docker\metadata_manager.cpp) [C:\mesos\src\mesos.vcxproj]
228 Warning(s)
2 Error(s)
Time Elapsed 00:14:51.31
```
- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471/logs/mesos-tests-CMakeOutput.log):
```
Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_f3af9.dir\Debug\cmTC_f3af9.tlog\".
InitializeBuildStatus:
Creating "cmTC_f3af9.dir\Debug\cmTC_f3af9.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_f3af9.dir\Debug\" /Fd"cmTC_f3af9.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_f3af9.dir\Debug\" /Fd"cmTC_f3af9.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_f3af9.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_f3af9.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_f3af9.lib" /MACHINE:X64 /machine:x64 cmTC_f3af9.dir\Debug\src.obj
cmTC_f3af9.vcxproj -> C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_f3af9.exe
cmTC_f3af9.vcxproj -> C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_f3af9.pdb (Full PDB)
FinalizeBuildStatus:
Deleting file "cmTC_f3af9.dir\Debug\cmTC_f3af9.tlog\unsuccessfulbuild".
Touching "cmTC_f3af9.dir\Debug\cmTC_f3af9.tlog\cmTC_f3af9.lastbuildstate".
Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_f3af9.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.78
Source file was:
int main() { return 0; }
```
- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471/logs/mesos-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_7cc0a.dir\Debug\".
Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_7cc0a.dir\Debug\cmTC_7cc0a.tlog\".
InitializeBuildStatus:
Creating "cmTC_7cc0a.dir\Debug\cmTC_7cc0a.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_7cc0a.dir\Debug\" /Fd"cmTC_7cc0a.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_7cc0a.dir\Debug\" /Fd"cmTC_7cc0a.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_7cc0a.vcxproj]
Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_7cc0a.vcxproj" (default targets) -- FAILED.
Build FAILED.
"C:\mesos\CMakeFiles\CMakeTmp\cmTC_7cc0a.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_7cc0a.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.95
```
- Mesos Reviewbot Windows
On Oct. 17, 2017, 10:06 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60471/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 10:06 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for pruneImages for containerizer and provisioner.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
> src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
>
>
> Diff: https://reviews.apache.org/r/60471/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/#review191309
-----------------------------------------------------------
FAIL: Some Mesos libprocess-tests failed.
Reviews applied: `['55334', '55335', '59687', '62997', '56721', '60471']`
Failed command: `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471
Relevant logs:
- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471/logs/libprocess-tests-stdout.log):
```
[ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0
[ OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 (832 ms)
[ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(446): error: (await_subprocess(client.get(), 0)).failure():
[++++++++++] Subprocess output.
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SSLClientTest
[ RUN ] SSLClientTest.client
[ OK ] SSLClientTest.client (18 ms)
[----------] 1 test from SSLClientTest (18 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (19 ms total)
[ PASSED ] 1 test.
[++++++++++]
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true" (866 ms)
[----------] 4 tests from SSLVerifyIPAdd/SSLTest (3239 ms total)
[----------] Global test environment tear-down
[==========] 201 tests from 33 test cases ran. (48150 ms total)
[ PASSED ] 200 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true"
1 FAILED TEST
YOU HAVE 19 DISABLED TESTS
```
- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471/logs/libprocess-tests-stderr.log):
```
I1117 09:36:52.682693 6108 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1117 09:36:52.682693 6108 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peWARNING: Logging before InitGoogleLogging() is written to STDERR
I1117 09:36:52.987694 1208 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1117 09:36:52.988692 1208 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1117 09:36:52.988692 1208 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1117 09:36:52.989694 1208 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\aQHRIm\cert.pem
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1117 09:36:53.918928 4204 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1117 09:36:53.920786 4204 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1117 09:36:53.920786 4204 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1117 09:36:53.920786 4204 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1117 09:36:53.920786 4204 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\4hlC2k\cert.pem
er certificate verification
I1117 09:36:52.692700 6108 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1117 09:36:52.692700 6108 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\aQHRIm\cert.pem
I1117 09:36:53.618780 6108 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1117 09:36:53.618780 6108 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1117 09:36:53.618780 6108 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1117 09:36:53.618780 6108 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1117 09:36:53.619781 6108 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\4hlC2k\cert.pem
I1117 09:36:54.182989 2596 process.cpp:1052] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Nov. 16, 2017, 9:36 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60471/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2017, 9:36 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for pruneImages for containerizer and provisioner.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp ce67def65aa65188aff10f5316fcd8b745d0abf2
> src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
>
>
> Diff: https://reviews.apache.org/r/60471/diff/10/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/#review191288
-----------------------------------------------------------
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 923 (patched)
<https://reviews.apache.org/r/60471/#comment269058>
ditto.
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 1199 (patched)
<https://reviews.apache.org/r/60471/#comment269067>
if you just need to prove the image reference is correct. why do you need this promise?
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 1229 (patched)
<https://reviews.apache.org/r/60471/#comment269066>
const string imageName = "fake-image";
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 1231-1235 (patched)
<https://reviews.apache.org/r/60471/#comment269062>
use createDockerImage().
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 1237-1242 (patched)
<https://reviews.apache.org/r/60471/#comment269063>
use createContainerInfo()
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 1244-1246 (patched)
<https://reviews.apache.org/r/60471/#comment269064>
use createTask()
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 1266 (patched)
<https://reviews.apache.org/r/60471/#comment269068>
do you really need to wait for the termination?
src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 1275 (patched)
<https://reviews.apache.org/r/60471/#comment269065>
1u for vector?
- Gilbert Song
On Nov. 16, 2017, 1:36 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60471/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2017, 1:36 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for pruneImages for containerizer and provisioner.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp ce67def65aa65188aff10f5316fcd8b745d0abf2
> src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
>
>
> Diff: https://reviews.apache.org/r/60471/diff/10/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/
-----------------------------------------------------------
(Updated Nov. 22, 2017, 10:50 p.m.)
Review request for mesos, Gilbert Song and Jason Lai.
Changes
-------
Rebase.
Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945
Repository: mesos
Description
-------
Added tests for pruneImages for containerizer and provisioner.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp 98adcfcfba4e5ee975b7ed0c073758ec2726763d
src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
Diff: https://reviews.apache.org/r/60471/diff/12/
Changes: https://reviews.apache.org/r/60471/diff/11-12/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/
-----------------------------------------------------------
(Updated Nov. 17, 2017, 4:50 p.m.)
Review request for mesos, Gilbert Song and Jason Lai.
Changes
-------
Review comments and further TODO for future tests.
Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945
Repository: mesos
Description
-------
Added tests for pruneImages for containerizer and provisioner.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp ce67def65aa65188aff10f5316fcd8b745d0abf2
src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
Diff: https://reviews.apache.org/r/60471/diff/11/
Changes: https://reviews.apache.org/r/60471/diff/10-11/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/
-----------------------------------------------------------
(Updated Nov. 16, 2017, 9:36 p.m.)
Review request for mesos, Gilbert Song and Jason Lai.
Changes
-------
Fix containerierzer->launch return value type.
Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945
Repository: mesos
Description
-------
Added tests for pruneImages for containerizer and provisioner.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp ce67def65aa65188aff10f5316fcd8b745d0abf2
src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
Diff: https://reviews.apache.org/r/60471/diff/10/
Changes: https://reviews.apache.org/r/60471/diff/9-10/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/#review191159
-----------------------------------------------------------
FAIL: Some Mesos libprocess-tests failed.
Reviews applied: `['55334', '55335', '59687', '62997', '56721', '56722', '62853', '60471']`
Failed command: `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471
Relevant logs:
- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471/logs/libprocess-tests-stdout.log):
```
[ OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 (1374 ms)
[ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(446): error: (await_subprocess(client.get(), 0)).failure():
[++++++++++] Subprocess output.
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SSLClientTest
[ RUN ] SSLClientTest.client
[ OK ] SSLClientTest.client (21 ms)
[----------] 1 test from SSLClientTest (21 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (22 ms total)
[ PASSED ] 1 test.
[++++++++++]
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true" (1017 ms)
[----------] 4 tests from SSLVerifyIPAdd/SSLTest (4731 ms total)
[----------] Global test environment tear-down
[==========] 201 tests from 33 test cases ran. (49240 ms total)
[ PASSED ] 199 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] SSLTest.VerifyCertificate
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true"
2 FAILED TESTS
YOU HAVE 19 DISABLED TESTS
```
- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471/logs/libprocess-tests-stderr.log):
```
I1116 07:47:55.984385 2084 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1116 07:47:55.984385 2084 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peWARNING: Logging before InitGoogleLogging() is written to STDERR
I1116 07:47:56.333386 5560 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1116 07:47:56.334388 5560 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1116 07:47:56.334388 5560 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1116 07:47:56.335388 5560 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\MxjpV5\cert.pem
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1116 07:47:57.327318 3356 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1116 07:47:57.328320 3356 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1116 07:47:57.329620 3356 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1116 07:47:57.329620 3356 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1116 07:47:57.330322 3356 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\nsdOec\cert.pem
er certificate verification
I1116 07:47:56.012396 2084 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1116 07:47:56.013386 2084 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\MxjpV5\cert.pem
I1116 07:47:57.018337 2084 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1116 07:47:57.019317 2084 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1116 07:47:57.019317 2084 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1116 07:47:57.019317 2084 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1116 07:47:57.019317 2084 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\nsdOec\cert.pem
I1116 07:47:57.654356 408 process.cpp:1052] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Nov. 16, 2017, 4:05 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60471/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2017, 4:05 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for pruneImages for containerizer and provisioner.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp ce67def65aa65188aff10f5316fcd8b745d0abf2
> src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
>
>
> Diff: https://reviews.apache.org/r/60471/diff/9/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/
-----------------------------------------------------------
(Updated Nov. 16, 2017, 4:05 a.m.)
Review request for mesos, Gilbert Song and Jason Lai.
Changes
-------
Rebase only.
Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945
Repository: mesos
Description
-------
Added tests for pruneImages for containerizer and provisioner.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp ce67def65aa65188aff10f5316fcd8b745d0abf2
src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef
Diff: https://reviews.apache.org/r/60471/diff/9/
Changes: https://reviews.apache.org/r/60471/diff/8-9/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 5:06 p.m.)
Review request for mesos, Gilbert Song and Jason Lai.
Changes
-------
Rebase chain and remove implemented TODO.
Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945
Repository: mesos
Description
-------
Added tests for pruneImages for containerizer and provisioner.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
Diff: https://reviews.apache.org/r/60471/diff/7/
Changes: https://reviews.apache.org/r/60471/diff/6-7/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/#review188324
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 62997.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62997`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471
Relevant logs:
- [apply-review-62997-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60471/logs/apply-review-62997-stdout.log):
```
error: patch failed: include/mesos/slave/containerizer.proto:248
error: include/mesos/slave/containerizer.proto: patch does not apply
```
- Mesos Reviewbot Windows
On Oct. 17, 2017, 3:31 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60471/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 3:31 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for pruneImages for containerizer and provisioner.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
> src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
>
>
> Diff: https://reviews.apache.org/r/60471/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60471: Added tests for pruneImages for
containerizer and provisioner.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 3:31 p.m.)
Review request for mesos, Gilbert Song and Jason Lai.
Changes
-------
Rewrite test to cover concurrency cases between `provision` and `pruneImages`, and make sure `recover` can recover layers for pruneImages.
Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945
Repository: mesos
Description
-------
Added tests for pruneImages for containerizer and provisioner.
Diffs (updated)
-----
src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee
src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
Diff: https://reviews.apache.org/r/60471/diff/6/
Changes: https://reviews.apache.org/r/60471/diff/5-6/
Testing
-------
Thanks,
Zhitao Li