[GitHub] [spark] yangwwei commented on pull request #35663: [SPARK-37809][K8S] Add `YuniKorn` Feature Step

[GitBox <gi...@apache.org>]

yangwwei commented on PR #35663:
URL: https://github.com/apache/spark/pull/35663#issuecomment-1218477399

   hi @dongjoon-hyun , @Yikun thanks for the comments, very good points. Let me work on the update. A few questions/comments in parallel:
   
   1. For docs like [here](https://github.com/apache/spark/blame/master/docs/running-on-kubernetes.md#L1728-L1813)  and  [here](https://github.com/apache/spark/tree/master/resource-managers/kubernetes/integration-tests#running-the-volcano-integration-tests). Can we address in another PR? Just want to keep this PR concise and focus on the code implementation.
   
   2. De-duplicate by reusing [SPARK-38383](https://issues.apache.org/jira/browse/SPARK-38383) and remove YuniKornFeatureStepSuite.scala.
   
   I think we still need to preserve the feature step. From Spark, we want to give a consistent user experience when people want to run Spark with customized schedulers. Volcano integration was exposed via FeatureStep, I prefer we do the same for YuniKorn. It will be easier for users to configure. What do you think? 
   
   If we remove this. Then the user-facing configs will be different. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org