[GitHub] [beam] pabloem commented on a change in pull request #11296: [BEAM-9640] Sketching watermark tracking on FnApiRunner

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #11296:
URL: https://github.com/apache/beam/pull/11296#discussion_r647808822



##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -364,10 +368,36 @@ def run_stages(self,
           bundle_context_manager = execution.BundleContextManager(
               runner_execution_context, stage, self._num_workers)
 
+          assert (
+              runner_execution_context.watermark_manager.get_stage_node(
+                  bundle_context_manager.stage.name
+              ).input_watermark() == timestamp.MAX_TIMESTAMP), (
+              'wrong watermark for %s. Expected %s, but got %s.' % (
+                  runner_execution_context.watermark_manager.get_stage_node(
+                      bundle_context_manager.stage.name),
+                  timestamp.MAX_TIMESTAMP,
+                  runner_execution_context.watermark_manager.get_stage_node(
+                      bundle_context_manager.stage.name
+                  ).input_watermark()
+              )
+          )
+
           stage_results = self._run_stage(
-              runner_execution_context,
-              bundle_context_manager,
+              runner_execution_context, bundle_context_manager)
+
+          assert (
+              runner_execution_context.watermark_manager.get_stage_node(
+                  bundle_context_manager.stage.name
+              ).input_watermark() == timestamp.MAX_TIMESTAMP), (

Review comment:
       ah thanks for the catch. fixed that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org