You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Maxim Solodovnik <so...@gmail.com> on 2016/09/10 17:37:12 UTC
Indicating dialog button don't stop
Hello Sebastien,
I'm struggling with indicating dialog button, after dialog re-open it
continue "indicating"
I can hack it (remove indicating icon, but this seems to be wrong solution :(
jQuery.event.trigger("ajaxStop");
Also seems to not work :(
What am I doing wrong?
--
WBR
Maxim aka solomax
Re: Indicating dialog button don't stop
Posted by Maxim Solodovnik <so...@gmail.com>.
sorry, my bad :(
On Sun, Sep 11, 2016 at 9:13 PM, Martin Grigorov
<ma...@gmail.com> wrote:
> Hi Maxim,
>
> Please use users@ for these questions.
> Thanks!
>
> On Sep 11, 2016 2:59 PM, "Maxim Solodovnik" <so...@gmail.com> wrote:
>
>> Thanks a lot Sebastien! :)))
>>
>> Another question: in some cases onClick handler on menuItem is not
>> working, could you please advise how to debug it?
>> weird thing it sometimes works and sometimes not :( so I need to start
>> debugging on maybe client side
>> what is the best way to do it?
>>
>> On Sun, Sep 11, 2016 at 6:23 PM, Sebastien <se...@gmail.com> wrote:
>> > Hi Maxim,
>> >
>> > It seems to be a bug on my side, I'm on it...
>> >
>> > Best regards,
>> > Sebastien.
>> >
>> >
>> > On Sun, Sep 11, 2016 at 6:57 AM, Maxim Solodovnik <so...@gmail.com>
>> > wrote:
>> >>
>> >> Thanks for the quick answer :)
>> >>
>> >> I'm opening dialog using open method [1]
>> >> In onOpen [2] method I'm adding some internal components (including
>> >> indicating button to enable it (another HACK))
>> >>
>> >> Actually the following scenario doesn't work:
>> >> I perform "heavy" file conversion in onSubmit method [3] in case error
>> >> happend, I'm not closing dialog and displaying error ....
>> >> And the indicating button is still "indicating" on this step
>> >>
>> >>
>> >> [1]
>> >> https://github.com/apache/openmeetings/blob/3.2.x/
>> openmeetings-web/src/main/java/org/apache/openmeetings/
>> web/room/sidebar/RoomSidebar.java#L224
>> >> [2]
>> >> https://github.com/apache/openmeetings/blob/3.2.x/
>> openmeetings-web/src/main/java/org/apache/openmeetings/
>> web/room/sidebar/UploadDialog.java#L165
>> >>
>> >> https://github.com/apache/openmeetings/blob/3.2.x/
>> openmeetings-web/src/main/java/org/apache/openmeetings/
>> web/room/sidebar/UploadDialog.java#L197
>> >>
>> >> On Sun, Sep 11, 2016 at 1:39 AM, Sebastien <se...@gmail.com> wrote:
>> >> > Hi Maxim,
>> >> >
>> >> > Are you re-attaching the dialog after the click somehow, like
>> >> > target.add(theDialogOrItsContainer) ?
>> >> >
>> >> > Best regards,
>> >> > Sebastien.
>> >> >
>> >> >
>> >> >
>> >> > On Sat, Sep 10, 2016 at 7:37 PM, Maxim Solodovnik <
>> solomax666@gmail.com>
>> >> > wrote:
>> >> >>
>> >> >> Hello Sebastien,
>> >> >>
>> >> >> I'm struggling with indicating dialog button, after dialog re-open it
>> >> >> continue "indicating"
>> >> >> I can hack it (remove indicating icon, but this seems to be wrong
>> >> >> solution
>> >> >> :(
>> >> >>
>> >> >> jQuery.event.trigger("ajaxStop");
>> >> >> Also seems to not work :(
>> >> >> What am I doing wrong?
>> >> >>
>> >> >> --
>> >> >> WBR
>> >> >> Maxim aka solomax
>> >> >
>> >> >
>> >>
>> >>
>> >>
>> >> --
>> >> WBR
>> >> Maxim aka solomax
>> >
>> >
>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
--
WBR
Maxim aka solomax
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Indicating dialog button don't stop
Posted by Martin Grigorov <ma...@gmail.com>.
Hi Maxim,
Please use users@ for these questions.
Thanks!
On Sep 11, 2016 2:59 PM, "Maxim Solodovnik" <so...@gmail.com> wrote:
> Thanks a lot Sebastien! :)))
>
> Another question: in some cases onClick handler on menuItem is not
> working, could you please advise how to debug it?
> weird thing it sometimes works and sometimes not :( so I need to start
> debugging on maybe client side
> what is the best way to do it?
>
> On Sun, Sep 11, 2016 at 6:23 PM, Sebastien <se...@gmail.com> wrote:
> > Hi Maxim,
> >
> > It seems to be a bug on my side, I'm on it...
> >
> > Best regards,
> > Sebastien.
> >
> >
> > On Sun, Sep 11, 2016 at 6:57 AM, Maxim Solodovnik <so...@gmail.com>
> > wrote:
> >>
> >> Thanks for the quick answer :)
> >>
> >> I'm opening dialog using open method [1]
> >> In onOpen [2] method I'm adding some internal components (including
> >> indicating button to enable it (another HACK))
> >>
> >> Actually the following scenario doesn't work:
> >> I perform "heavy" file conversion in onSubmit method [3] in case error
> >> happend, I'm not closing dialog and displaying error ....
> >> And the indicating button is still "indicating" on this step
> >>
> >>
> >> [1]
> >> https://github.com/apache/openmeetings/blob/3.2.x/
> openmeetings-web/src/main/java/org/apache/openmeetings/
> web/room/sidebar/RoomSidebar.java#L224
> >> [2]
> >> https://github.com/apache/openmeetings/blob/3.2.x/
> openmeetings-web/src/main/java/org/apache/openmeetings/
> web/room/sidebar/UploadDialog.java#L165
> >>
> >> https://github.com/apache/openmeetings/blob/3.2.x/
> openmeetings-web/src/main/java/org/apache/openmeetings/
> web/room/sidebar/UploadDialog.java#L197
> >>
> >> On Sun, Sep 11, 2016 at 1:39 AM, Sebastien <se...@gmail.com> wrote:
> >> > Hi Maxim,
> >> >
> >> > Are you re-attaching the dialog after the click somehow, like
> >> > target.add(theDialogOrItsContainer) ?
> >> >
> >> > Best regards,
> >> > Sebastien.
> >> >
> >> >
> >> >
> >> > On Sat, Sep 10, 2016 at 7:37 PM, Maxim Solodovnik <
> solomax666@gmail.com>
> >> > wrote:
> >> >>
> >> >> Hello Sebastien,
> >> >>
> >> >> I'm struggling with indicating dialog button, after dialog re-open it
> >> >> continue "indicating"
> >> >> I can hack it (remove indicating icon, but this seems to be wrong
> >> >> solution
> >> >> :(
> >> >>
> >> >> jQuery.event.trigger("ajaxStop");
> >> >> Also seems to not work :(
> >> >> What am I doing wrong?
> >> >>
> >> >> --
> >> >> WBR
> >> >> Maxim aka solomax
> >> >
> >> >
> >>
> >>
> >>
> >> --
> >> WBR
> >> Maxim aka solomax
> >
> >
>
>
>
> --
> WBR
> Maxim aka solomax
>
Re: Indicating dialog button don't stop
Posted by Maxim Solodovnik <so...@gmail.com>.
Hello Sebastien,
sorry for the late response was too busy to check :((
Everything works as expected in samples, will check my code
Thanks a lot for the fix!
On Tue, Sep 13, 2016 at 3:01 AM, Sebastien <se...@gmail.com> wrote:
> Hi Maxim,
>
> This is not intended that the dialog flickers... This is weird and I don't
> see any reason (and I don't see this on my side...)
>
> Can you run the "upload dialog" sample of wicket-jquery-ui-samples to see
> if you do repro it ?
>
> > git clone https://github.com/sebfz1/wicket-jquery-ui.git
> > cd wicket-jquery-ui
> > mvn clean install
> > cd wicket-jquery-ui-samples
> > mvn jetty:run
> (AFAIR)
>
> Thanks in advance,
> Sébastien
>
--
WBR
Maxim aka solomax
Re: Indicating dialog button don't stop
Posted by Sebastien <se...@gmail.com>.
Hi Maxim,
This is not intended that the dialog flickers... This is weird and I don't
see any reason (and I don't see this on my side...)
Can you run the "upload dialog" sample of wicket-jquery-ui-samples to see
if you do repro it ?
> git clone https://github.com/sebfz1/wicket-jquery-ui.git
> cd wicket-jquery-ui
> mvn clean install
> cd wicket-jquery-ui-samples
> mvn jetty:run
(AFAIR)
Thanks in advance,
Sébastien
Re: Indicating dialog button don't stop
Posted by Maxim Solodovnik <so...@gmail.com>.
Thanks a lot for the SNAPSHOT
It works as expected :) the only issue I was able to see is: dialog
flickers while waiting ... is it expected?
Thanks for the steps will try to use it to debug broken menu item,
will write back :)
On Mon, Sep 12, 2016 at 5:23 AM, Sebastien <se...@gmail.com> wrote:
> Hi Maxim,
>
> I've deployed 7.4.1-SNAPSHOT with the fix.
>
> About debugging the client side, you would :
> - watch the dev tool / network ajax requests and response
> - watch the ajax debug window if there is any js commands in the ajax
> response that has not effect (you can copy/paste them in the brower's dev
> console)
> - look at the rendered source, also for the js commands in the widget
> initialization
> - clone wicket-jquery-ui and put some 'console.log' in the relevant
> javascript statements.
> - if still no clue, start from scratch in a quickstart... :/
>
> Hope this helps,
> Sebastien
>
>
--
WBR
Maxim aka solomax
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Indicating dialog button don't stop
Posted by Sebastien <se...@gmail.com>.
Hi Maxim,
I've deployed 7.4.1-SNAPSHOT with the fix.
About debugging the client side, you would :
- watch the dev tool / network ajax requests and response
- watch the ajax debug window if there is any js commands in the ajax
response that has not effect (you can copy/paste them in the brower's dev
console)
- look at the rendered source, also for the js commands in the widget
initialization
- clone wicket-jquery-ui and put some 'console.log' in the relevant
javascript statements.
- if still no clue, start from scratch in a quickstart... :/
Hope this helps,
Sebastien
Re: Indicating dialog button don't stop
Posted by Maxim Solodovnik <so...@gmail.com>.
Thanks a lot Sebastien! :)))
Another question: in some cases onClick handler on menuItem is not
working, could you please advise how to debug it?
weird thing it sometimes works and sometimes not :( so I need to start
debugging on maybe client side
what is the best way to do it?
On Sun, Sep 11, 2016 at 6:23 PM, Sebastien <se...@gmail.com> wrote:
> Hi Maxim,
>
> It seems to be a bug on my side, I'm on it...
>
> Best regards,
> Sebastien.
>
>
> On Sun, Sep 11, 2016 at 6:57 AM, Maxim Solodovnik <so...@gmail.com>
> wrote:
>>
>> Thanks for the quick answer :)
>>
>> I'm opening dialog using open method [1]
>> In onOpen [2] method I'm adding some internal components (including
>> indicating button to enable it (another HACK))
>>
>> Actually the following scenario doesn't work:
>> I perform "heavy" file conversion in onSubmit method [3] in case error
>> happend, I'm not closing dialog and displaying error ....
>> And the indicating button is still "indicating" on this step
>>
>>
>> [1]
>> https://github.com/apache/openmeetings/blob/3.2.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/sidebar/RoomSidebar.java#L224
>> [2]
>> https://github.com/apache/openmeetings/blob/3.2.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/sidebar/UploadDialog.java#L165
>>
>> https://github.com/apache/openmeetings/blob/3.2.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/sidebar/UploadDialog.java#L197
>>
>> On Sun, Sep 11, 2016 at 1:39 AM, Sebastien <se...@gmail.com> wrote:
>> > Hi Maxim,
>> >
>> > Are you re-attaching the dialog after the click somehow, like
>> > target.add(theDialogOrItsContainer) ?
>> >
>> > Best regards,
>> > Sebastien.
>> >
>> >
>> >
>> > On Sat, Sep 10, 2016 at 7:37 PM, Maxim Solodovnik <so...@gmail.com>
>> > wrote:
>> >>
>> >> Hello Sebastien,
>> >>
>> >> I'm struggling with indicating dialog button, after dialog re-open it
>> >> continue "indicating"
>> >> I can hack it (remove indicating icon, but this seems to be wrong
>> >> solution
>> >> :(
>> >>
>> >> jQuery.event.trigger("ajaxStop");
>> >> Also seems to not work :(
>> >> What am I doing wrong?
>> >>
>> >> --
>> >> WBR
>> >> Maxim aka solomax
>> >
>> >
>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>
>
--
WBR
Maxim aka solomax
Re: Indicating dialog button don't stop
Posted by Sebastien <se...@gmail.com>.
Hi Maxim,
It seems to be a bug on my side, I'm on it...
Best regards,
Sebastien.
On Sun, Sep 11, 2016 at 6:57 AM, Maxim Solodovnik <so...@gmail.com>
wrote:
> Thanks for the quick answer :)
>
> I'm opening dialog using open method [1]
> In onOpen [2] method I'm adding some internal components (including
> indicating button to enable it (another HACK))
>
> Actually the following scenario doesn't work:
> I perform "heavy" file conversion in onSubmit method [3] in case error
> happend, I'm not closing dialog and displaying error ....
> And the indicating button is still "indicating" on this step
>
>
> [1] https://github.com/apache/openmeetings/blob/3.2.x/
> openmeetings-web/src/main/java/org/apache/openmeetings/
> web/room/sidebar/RoomSidebar.java#L224
> [2] https://github.com/apache/openmeetings/blob/3.2.x/
> openmeetings-web/src/main/java/org/apache/openmeetings/
> web/room/sidebar/UploadDialog.java#L165
> https://github.com/apache/openmeetings/blob/3.2.x/
> openmeetings-web/src/main/java/org/apache/openmeetings/
> web/room/sidebar/UploadDialog.java#L197
>
> On Sun, Sep 11, 2016 at 1:39 AM, Sebastien <se...@gmail.com> wrote:
> > Hi Maxim,
> >
> > Are you re-attaching the dialog after the click somehow, like
> > target.add(theDialogOrItsContainer) ?
> >
> > Best regards,
> > Sebastien.
> >
> >
> >
> > On Sat, Sep 10, 2016 at 7:37 PM, Maxim Solodovnik <so...@gmail.com>
> > wrote:
> >>
> >> Hello Sebastien,
> >>
> >> I'm struggling with indicating dialog button, after dialog re-open it
> >> continue "indicating"
> >> I can hack it (remove indicating icon, but this seems to be wrong
> solution
> >> :(
> >>
> >> jQuery.event.trigger("ajaxStop");
> >> Also seems to not work :(
> >> What am I doing wrong?
> >>
> >> --
> >> WBR
> >> Maxim aka solomax
> >
> >
>
>
>
> --
> WBR
> Maxim aka solomax
>
Re: Indicating dialog button don't stop
Posted by Maxim Solodovnik <so...@gmail.com>.
Thanks for the quick answer :)
I'm opening dialog using open method [1]
In onOpen [2] method I'm adding some internal components (including
indicating button to enable it (another HACK))
Actually the following scenario doesn't work:
I perform "heavy" file conversion in onSubmit method [3] in case error
happend, I'm not closing dialog and displaying error ....
And the indicating button is still "indicating" on this step
[1] https://github.com/apache/openmeetings/blob/3.2.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/sidebar/RoomSidebar.java#L224
[2] https://github.com/apache/openmeetings/blob/3.2.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/sidebar/UploadDialog.java#L165
https://github.com/apache/openmeetings/blob/3.2.x/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/sidebar/UploadDialog.java#L197
On Sun, Sep 11, 2016 at 1:39 AM, Sebastien <se...@gmail.com> wrote:
> Hi Maxim,
>
> Are you re-attaching the dialog after the click somehow, like
> target.add(theDialogOrItsContainer) ?
>
> Best regards,
> Sebastien.
>
>
>
> On Sat, Sep 10, 2016 at 7:37 PM, Maxim Solodovnik <so...@gmail.com>
> wrote:
>>
>> Hello Sebastien,
>>
>> I'm struggling with indicating dialog button, after dialog re-open it
>> continue "indicating"
>> I can hack it (remove indicating icon, but this seems to be wrong solution
>> :(
>>
>> jQuery.event.trigger("ajaxStop");
>> Also seems to not work :(
>> What am I doing wrong?
>>
>> --
>> WBR
>> Maxim aka solomax
>
>
--
WBR
Maxim aka solomax
Re: Indicating dialog button don't stop
Posted by Sebastien <se...@gmail.com>.
Hi Maxim,
Are you re-attaching the dialog after the click somehow, like
target.add(theDialogOrItsContainer) ?
Best regards,
Sebastien.
On Sat, Sep 10, 2016 at 7:37 PM, Maxim Solodovnik <so...@gmail.com>
wrote:
> Hello Sebastien,
>
> I'm struggling with indicating dialog button, after dialog re-open it
> continue "indicating"
> I can hack it (remove indicating icon, but this seems to be wrong solution
> :(
>
> jQuery.event.trigger("ajaxStop");
> Also seems to not work :(
> What am I doing wrong?
>
> --
> WBR
> Maxim aka solomax
>