You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/04 23:02:08 UTC

[GitHub] [airflow] potiuk commented on issue #6496: [AIRFLOW-5704] Improve Kind Kubernetes scripts for local testing. Depends on [AIRFLOW-5830] [AIRFLOW-5829]

potiuk commented on issue #6496: [AIRFLOW-5704] Improve Kind Kubernetes scripts for local testing. Depends on [AIRFLOW-5830] [AIRFLOW-5829]
URL: https://github.com/apache/airflow/pull/6496#issuecomment-549587220
 
 
   I actually will improve it even further @gerardo -> when I get the prod image up and running i will actually use this production image for those tests. Which will basically mean that we will test both the Kubernetes Tests and Production image at the same time (and it will be way smaller so it's likely we will have much faster tests overall  :). Vast majority of the test now is just preparation of the environment and particularly exporting/loading the Airflow images :(. 
   
   What do you mean by resetting the cluster ? From what I understand the "deploy_app.sh" script will actually delete the pods - postgres/airflow/webserver. This will effectively destroy any state - i.e. the postgres volume, and next time when we redeploy the app we anyhow run "initContainer" in the airflow.yaml (airflow-test-env-init.sh) which will perform `airflow initdb`. So I think just making sure that we redeploy the app before rerunning test is enough?
   
   If we want to re-run tests, presumably we want to do it because we modified code, so we have to rebuild and re-deploy the application (after building the image) so we should be fine anyway ?
   
   I just now will have to make an easy way to trigger it for iterative development. 
   
   I think it should be possible to rebuild the image and re-deploy app with a single trigger from the host without even restarting breeze. I will likely have to mount the whole folder rather than single file to let the exported .tar file to be updated in container.  
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services