You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/10/13 00:31:19 UTC

Review Request 62962: Added doc for cgroups/cpu isolator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62962/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jie Yu, and James Peach.


Repository: mesos


Description
-------

Added doc for cgroups/cpu isolator.


Diffs
-----

  docs/isolators/cgroups-cpu.md PRE-CREATION 
  docs/mesos-containerizer.md 68ed273786d77054eb7973e8f2804138fa2ffff9 


Diff: https://reviews.apache.org/r/62962/diff/1/


Testing
-------

Verified on GitHub https://github.com/ipronin/mesos/blob/docathon/docs/isolators/cgroups-cpu.md


Thanks,

Ilya Pronin

Re: Review Request 62962: Added doc for cgroups/cpu isolator.

Posted by Ilya Pronin <ip...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62962/
-----------------------------------------------------------

(Updated Oct. 12, 2017, 5:44 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and James Peach.


Changes
-------

Addressed review comments.


Repository: mesos


Description
-------

Added doc for cgroups/cpu isolator.


Diffs (updated)
-----

  docs/isolators/cgroups-cpu.md PRE-CREATION 
  docs/mesos-containerizer.md 68ed273786d77054eb7973e8f2804138fa2ffff9 


Diff: https://reviews.apache.org/r/62962/diff/2/

Changes: https://reviews.apache.org/r/62962/diff/1-2/


Testing
-------

Verified on GitHub https://github.com/ipronin/mesos/blob/docathon/docs/isolators/cgroups-cpu.md


Thanks,

Ilya Pronin

Re: Review Request 62962: Added doc for cgroups/cpu isolator.

Posted by Ilya Pronin <ip...@twopensource.com>.

> On Oct. 12, 2017, 5:40 p.m., Jie Yu wrote:
> > docs/isolators/cgroups-cpu.md
> > Lines 26 (patched)
> > <https://reviews.apache.org/r/62962/diff/1/?file=1854299#file1854299line26>
> >
> >     this is a bit confusing. i would refrash that `this mechanism is always enabled when you turn on this isolator.`

Rephrased.


> On Oct. 12, 2017, 5:40 p.m., Jie Yu wrote:
> > docs/isolators/cgroups-cpu.md
> > Lines 42 (patched)
> > <https://reviews.apache.org/r/62962/diff/1/?file=1854299#file1854299line42>
> >
> >     I would say this is "Effects on application when using CFS Bandwidth Limiting"

Fixed.


> On Oct. 12, 2017, 5:40 p.m., Jie Yu wrote:
> > docs/isolators/cgroups-cpu.md
> > Lines 48 (patched)
> > <https://reviews.apache.org/r/62962/diff/1/?file=1854299#file1854299line48>
> >
> >     that are latency sensitive?

Yes :)


- Ilya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62962/#review187910
-----------------------------------------------------------


On Oct. 12, 2017, 5:44 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62962/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 5:44 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added doc for cgroups/cpu isolator.
> 
> 
> Diffs
> -----
> 
>   docs/isolators/cgroups-cpu.md PRE-CREATION 
>   docs/mesos-containerizer.md 68ed273786d77054eb7973e8f2804138fa2ffff9 
> 
> 
> Diff: https://reviews.apache.org/r/62962/diff/2/
> 
> 
> Testing
> -------
> 
> Verified on GitHub https://github.com/ipronin/mesos/blob/docathon/docs/isolators/cgroups-cpu.md
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>

Re: Review Request 62962: Added doc for cgroups/cpu isolator.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62962/#review187910
-----------------------------------------------------------


Fix it, then Ship it!





docs/isolators/cgroups-cpu.md
Lines 26 (patched)
<https://reviews.apache.org/r/62962/#comment264976>

    this is a bit confusing. i would refrash that `this mechanism is always enabled when you turn on this isolator.`



docs/isolators/cgroups-cpu.md
Lines 42 (patched)
<https://reviews.apache.org/r/62962/#comment264980>

    I would say this is "Effects on application when using CFS Bandwidth Limiting"



docs/isolators/cgroups-cpu.md
Lines 48 (patched)
<https://reviews.apache.org/r/62962/#comment264978>

    that are latency sensitive?


- Jie Yu


On Oct. 13, 2017, 12:31 a.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62962/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 12:31 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added doc for cgroups/cpu isolator.
> 
> 
> Diffs
> -----
> 
>   docs/isolators/cgroups-cpu.md PRE-CREATION 
>   docs/mesos-containerizer.md 68ed273786d77054eb7973e8f2804138fa2ffff9 
> 
> 
> Diff: https://reviews.apache.org/r/62962/diff/1/
> 
> 
> Testing
> -------
> 
> Verified on GitHub https://github.com/ipronin/mesos/blob/docathon/docs/isolators/cgroups-cpu.md
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>