You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/16 20:55:05 UTC

[GitHub] [beam] tysonjh commented on a change in pull request #15184: [BEAM-12589] - exclude testTwoTimersSettingEachOtherWithCreateAsInput…

tysonjh commented on a change in pull request #15184:
URL: https://github.com/apache/beam/pull/15184#discussion_r671520127



##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -319,7 +321,6 @@ task validatesRunnerStreaming {
       'org.apache.beam.sdk.testing.UsesMapState',
       'org.apache.beam.sdk.testing.UsesRequiresTimeSortedInput',
       'org.apache.beam.sdk.testing.UsesSetState',
-      'org.apache.beam.sdk.testing.UsesStrictTimerOrdering',
     ],

Review comment:
       Ya it's fine. The `validatesRunnerStreaming` task uses the `createLegacyWorkerValidatesRunnerTest` method to build the task which iterates through `commonLegacyExcludeCategories` and adds all of those tests to the exclude pattern. Both batch and streaming use that method, there is a similar one for runnerv2.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org