[GitHub] [incubator-tvm] jroesch commented on pull request #6274: [Diagnostics][Relay][InferType] Refactor InferType to work on whole module, and use new diagnostics.

[GitBox <gi...@apache.org>]

jroesch commented on pull request #6274:
URL: https://github.com/apache/incubator-tvm/pull/6274#issuecomment-700416421


   @mbrookhart in theory they are decoupled the problem is that the diagnostics are now using the parser to generate synthetic files, and the parser uses the type checker to check the parsed files, and the type checker is using the diagnostics machinery. The branch started with me trying to just turn on the diagnostics in the type checker and all these changes are the result of me fixing bugs and design mistakes that blocked it from working. 
   
   RE: the typechecker many people were implicitly using the fact that module additions were type checked eagerly when calling `Add` on the module. 
   
   This behavior has multiple design issues and lead to the type checker being called more often then necessary as well as making it impossible to cleanly do things like recursive definitions, necessitated ordered handling of additions to the module, and two pass parsing to resolve names when generating the synthetic files as well as some other issues. 
   
   Others such as @junrushao1994 have sent an RFC asking to remove this behavior in the past from his exp. working on Meta at AWS.
   
   Also around 60% of additions are just repairing test cases that break from the type checker changing behavior. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org