You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/03/06 01:06:25 UTC
[GitHub] [hive] jcamachor opened a new pull request #938: HIVE-22978
jcamachor opened a new pull request #938: HIVE-22978
URL: https://github.com/apache/hive/pull/938
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vineetgarg02 commented on a change in pull request #938:
HIVE-22978
Posted by GitBox <gi...@apache.org>.
vineetgarg02 commented on a change in pull request #938: HIVE-22978
URL: https://github.com/apache/hive/pull/938#discussion_r389846825
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveTypeSystemImpl.java
##########
@@ -37,6 +39,14 @@
private static final int MAX_BINARY_PRECISION = Integer.MAX_VALUE;
private static final int MAX_TIMESTAMP_PRECISION = 9;
private static final int MAX_TIMESTAMP_WITH_LOCAL_TIME_ZONE_PRECISION = 15; // Up to nanos
+ private static final int DEFAULT_BOOLEAN_PRECISION = 1;
Review comment:
What does BOOLEAN with precision 1 mean? I thought precision only pertain to numeric data type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asfgit closed pull request #938: HIVE-22978
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #938: HIVE-22978
URL: https://github.com/apache/hive/pull/938
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #938:
HIVE-22978
Posted by GitBox <gi...@apache.org>.
jcamachor commented on a change in pull request #938: HIVE-22978
URL: https://github.com/apache/hive/pull/938#discussion_r390045244
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveTypeSystemImpl.java
##########
@@ -37,6 +39,14 @@
private static final int MAX_BINARY_PRECISION = Integer.MAX_VALUE;
private static final int MAX_TIMESTAMP_PRECISION = 9;
private static final int MAX_TIMESTAMP_WITH_LOCAL_TIME_ZONE_PRECISION = 15; // Up to nanos
+ private static final int DEFAULT_BOOLEAN_PRECISION = 1;
Review comment:
I think you are right. Implementation in Calcite has it defined for Boolean since I think they consider precision as length... However, I do not think it makes much sense. I have removed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vineetgarg02 commented on a change in pull request #938:
HIVE-22978
Posted by GitBox <gi...@apache.org>.
vineetgarg02 commented on a change in pull request #938: HIVE-22978
URL: https://github.com/apache/hive/pull/938#discussion_r390027730
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveTypeSystemImpl.java
##########
@@ -148,4 +172,17 @@ public boolean isSchemaCaseSensitive() {
return false;
}
+ @Override
+ public RelDataType deriveSumType(RelDataTypeFactory typeFactory,
Review comment:
Can you add a comment explaining why is this being done? Adding 10 seems arbitrary without the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org