You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sh...@apache.org on 2013/07/25 00:49:22 UTC
git commit: [CB-4355] Splashscreen plugin handles options incorrectly
(the settings key is specified with upper case chars)
Updated Branches:
refs/heads/master c9b85f18f -> 33f353d2e
[CB-4355] Splashscreen plugin handles options incorrectly (the settings key is specified with upper case chars)
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/commit/33f353d2
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/tree/33f353d2
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/diff/33f353d2
Branch: refs/heads/master
Commit: 33f353d2e9684e189f8b7d59c066253f2fe73f48
Parents: c9b85f1
Author: Shazron Abdullah <sh...@apache.org>
Authored: Wed Jul 24 15:48:59 2013 -0700
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Wed Jul 24 15:48:59 2013 -0700
----------------------------------------------------------------------
src/ios/CDVSplashScreen.m | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/blob/33f353d2/src/ios/CDVSplashScreen.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVSplashScreen.m b/src/ios/CDVSplashScreen.m
index fdb79fa..ba8d108 100644
--- a/src/ios/CDVSplashScreen.m
+++ b/src/ios/CDVSplashScreen.m
@@ -42,7 +42,7 @@
- (void)pageDidLoad
{
- id autoHideSplashScreenValue = [self.commandDelegate.settings objectForKey:@"AutoHideSplashScreen"];
+ id autoHideSplashScreenValue = [self.commandDelegate.settings objectForKey:[@"AutoHideSplashScreen" lowercaseString]];
// if value is missing, default to yes
if ((autoHideSplashScreenValue == nil) || [autoHideSplashScreenValue boolValue]) {
@@ -65,7 +65,7 @@
* gray = UIActivityIndicatorViewStyleGray
*
*/
- NSString* topActivityIndicator = [self.commandDelegate.settings objectForKey:@"TopActivityIndicator"];
+ NSString* topActivityIndicator = [self.commandDelegate.settings objectForKey:[@"TopActivityIndicator" lowercaseString]];
UIActivityIndicatorViewStyle topActivityIndicatorStyle = UIActivityIndicatorViewStyleGray;
if ([topActivityIndicator isEqualToString:@"whiteLarge"]) {
@@ -88,7 +88,7 @@
_imageView = [[UIImageView alloc] init];
[parentView addSubview:_imageView];
- id showSplashScreenSpinnerValue = [self.commandDelegate.settings objectForKey:@"ShowSplashScreenSpinner"];
+ id showSplashScreenSpinnerValue = [self.commandDelegate.settings objectForKey:[@"ShowSplashScreenSpinner" lowercaseString]];
// backwards compatibility - if key is missing, default to true
if ((showSplashScreenSpinnerValue == nil) || [showSplashScreenSpinnerValue boolValue]) {
[parentView addSubview:_activityView];
@@ -196,8 +196,8 @@
}
_visible = visible;
- id fadeSplashScreenValue = [self.commandDelegate.settings objectForKey:@"FadeSplashScreen"];
- id fadeSplashScreenDuration = [self.commandDelegate.settings objectForKey:@"FadeSplashScreenDuration"];
+ id fadeSplashScreenValue = [self.commandDelegate.settings objectForKey:[@"FadeSplashScreen" lowercaseString]];
+ id fadeSplashScreenDuration = [self.commandDelegate.settings objectForKey:[@"FadeSplashScreenDuration" lowercaseString]];
float fadeDuration = fadeSplashScreenDuration == nil ? kSplashScreenDurationDefault : [fadeSplashScreenDuration floatValue];