You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/11/16 22:14:32 UTC
Review Request: SQOOP-677 Destroyer needs to be called from OutputCommitter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8091/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've implemented calling Destroyer from job's OutputComitter.
This addresses bug SQOOP-677.
https://issues.apache.org/jira/browse/SQOOP-677
Diffs
-----
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java 7f952ac43838c8cc21d7ac117d50531dd7321a51
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java a53fa595007c5f3b3bb3bd053a6171658f3cc294
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java c9c9cf4deb59994da8ebf7937e5f17521fbd8102
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java PRE-CREATION
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java c465f10113b8c1170336bb41ba2ad7244c58ede4
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 1242f90c8de4f267509592abf15195085151bab2
spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java c8dc7c3d185c1d67f1c1292678c26e62855cc714
Diff: https://reviews.apache.org/r/8091/diff/
Testing
-------
Unit tests seems to be passing and I've tested it on real cluster.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-677 Destroyer needs to be called from
OutputCommitter
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8091/#review13734
-----------------------------------------------------------
Ship it!
Ship It!
- Bilung Lee
On Nov. 16, 2012, 9:14 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8091/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2012, 9:14 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've implemented calling Destroyer from job's OutputComitter.
>
>
> This addresses bug SQOOP-677.
> https://issues.apache.org/jira/browse/SQOOP-677
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java 7f952ac43838c8cc21d7ac117d50531dd7321a51
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java a53fa595007c5f3b3bb3bd053a6171658f3cc294
> core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java c9c9cf4deb59994da8ebf7937e5f17521fbd8102
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java c465f10113b8c1170336bb41ba2ad7244c58ede4
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 1242f90c8de4f267509592abf15195085151bab2
> spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java c8dc7c3d185c1d67f1c1292678c26e62855cc714
>
> Diff: https://reviews.apache.org/r/8091/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've tested it on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>