You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/18 02:14:12 UTC

[GitHub] [calcite] wangzzu opened a new pull request #1111: [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent

wangzzu opened a new pull request #1111: [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent
URL: https://github.com/apache/calcite/pull/1111
 
 
   In the javadoc of computeImportance(), it shows the importance of node is Sum{computeImportanceOfChild()}, but in the implementation it shows Max{computeImportanceOfChild()}, this is inconsistent. The Javadoc has some errors, it will cause some confusion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services