You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/23 11:12:36 UTC
[GitHub] [incubator-doris] wutiangan commented on a change in pull request
#3135: support subquery in case when statement
wutiangan commented on a change in pull request #3135: support subquery in case when statement
URL: https://github.com/apache/incubator-doris/pull/3135#discussion_r396373763
##########
File path: fe/src/main/java/org/apache/doris/analysis/SelectList.java
##########
@@ -83,7 +84,18 @@ public void reset() {
public void rewriteExprs(ExprRewriter rewriter, Analyzer analyzer)
throws AnalysisException {
for (SelectListItem item : items) {
- if (item.isStar()) continue;
+ if (item.isStar()) {
+ continue;
+ }
+ // when select list contain case when, for now subquery is supported in case-when
+ // (or more subquery is supported in future) so subquery all need to rewrite
Review comment:
The meaning of these two lines is not clear。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org