[GitHub] [iceberg] rdblue commented on a change in pull request #3640: Core: Support case sensitivity in MergingSnapshotProducer

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3640:
URL: https://github.com/apache/iceberg/pull/3640#discussion_r761496244



##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -125,6 +127,16 @@ public ThisT set(String property, String value) {
     return self();
   }
 
+  protected void caseSensitiveBinding(boolean newCaseSensitive) {

Review comment:
       I think the argument name matters less than the method name. Why does this use `caseSensitiveBinding`? Why not add `caseSensitive` and use that as the implementation? We already have a type parameter for the class (`ThisT`) and a `self()` method so we can implement a chainable call here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org