You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/31 10:43:37 UTC
[GitHub] [skywalking] kezhenxu94 opened a new issue #4155: Decrease log
level when byte buddy failed to match type
kezhenxu94 opened a new issue #4155: Decrease log level when byte buddy failed to match type
URL: https://github.com/apache/skywalking/issues/4155
https://github.com/apache/skywalking/blob/8a97aad021b16eb72591323691e902b06bd54087/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/ProtectiveShieldMatcher.java#L45-L51
I'd like to raise a discussion on the log level in the above code snippet.
For some reasons, in some of our applications, we have many classes that are failed to be resolved by byte buddy, and cases are that the applications all work well including the SkyWalking agent, but the logs are somewhat overwhelming, I've found an old issue https://github.com/raphw/byte-buddy/issues/373 , and seems this exception is mostly harmless, so I'm wondering whether we could just log this kind of logs in `DEBUG` level, what's your opinion, @wu-sheng @ascrutae @JaredTan95 @dmsolr @arugal etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4155: Decrease log level
when byte buddy failed to match type
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4155: Decrease log level when byte buddy failed to match type
URL: https://github.com/apache/skywalking/issues/4155#issuecomment-569925568
It is harmless for the target application, yes. But this could make plugin failure if the target class is the instrumentation target. :)
I am OK to change the log level to debug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 closed issue #4155: Decrease log level when
byte buddy failed to match type
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #4155: Decrease log level when byte buddy failed to match type
URL: https://github.com/apache/skywalking/issues/4155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services