[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests

[GitBox <gi...@apache.org>]

nuclearpinguin commented on a change in pull request #6299: [AIRFLOW-5631] Change way of running GCP system tests
URL: https://github.com/apache/airflow/pull/6299#discussion_r342221888
 
 

 ##########
 File path: tests/gcp/operators/test_bigquery_system.py
 ##########
 @@ -17,40 +17,32 @@
 # specific language governing permissions and limitations
 # under the License.
 """System tests for Google Cloud Build operators"""
-import unittest
 
 from tests.gcp.operators.test_bigquery_system_helper import GCPBigQueryTestHelper
-from tests.gcp.utils.base_gcp_system_test_case import SKIP_TEST_WARNING, TestDagGcpSystem
 from tests.gcp.utils.gcp_authenticator import GCP_BIGQUERY_KEY
+from tests.test_utils.gcp_system_helpers import GCP_DAG_FOLDER, provide_gcp_context, skip_gcp_system
+from tests.test_utils.system_tests_class import SystemTest
 
 
-@unittest.skipIf(TestDagGcpSystem.skip_check(GCP_BIGQUERY_KEY), SKIP_TEST_WARNING)
-class BigQueryExampleDagsSystemTest(TestDagGcpSystem):
+@skip_gcp_system(GCP_BIGQUERY_KEY, require_local_executor=True)
 
 Review comment:
   Yes, I agree. Can you make a PR with fix because I am on holidays?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services