You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/28 06:50:35 UTC

[GitHub] [rocketmq-client-go] hzjiangjian opened a new pull request #436: fix(producer): update name server address immediately when client start

hzjiangjian opened a new pull request #436: fix(producer): update name server address immediately when client start
URL: https://github.com/apache/rocketmq-client-go/pull/436
 
 
   Function UpdateNameServerAddress, which is first called after 10s from now, should be called immediately. Or Publish will end up with error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] codecov-io commented on issue #436: fix(producer): update name server address immediately when client start

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #436: fix(producer): update name server address immediately when client start
URL: https://github.com/apache/rocketmq-client-go/pull/436#issuecomment-592369270
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/436?src=pr&el=h1) Report
   > Merging [#436](https://codecov.io/gh/apache/rocketmq-client-go/pull/436?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/af4067cae785c6e632df9f0f5c689e7d5aa86646?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/436/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/436?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           native     #436      +/-   ##
   ==========================================
   - Coverage   24.82%   24.81%   -0.01%     
   ==========================================
     Files          48       48              
     Lines        5547     5548       +1     
   ==========================================
     Hits         1377     1377              
   - Misses       3982     3983       +1     
     Partials      188      188
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/436?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/436/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.23% <0%> (-0.01%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/436?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/436?src=pr&el=footer). Last update [af4067c...35303f0](https://codecov.io/gh/apache/rocketmq-client-go/pull/436?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] ShannonDing merged pull request #436: fix(producer): update name server address immediately when client start

Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #436: fix(producer): update name server address immediately when client start
URL: https://github.com/apache/rocketmq-client-go/pull/436
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services