You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by joewitt <gi...@git.apache.org> on 2017/12/03 22:47:06 UTC
[GitHub] nifi pull request #2313: NIFI-4652 updating to latest apache version and upd...
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/2313
NIFI-4652 updating to latest apache version and updating key maven pl…
Not for review yet. Helping currently with validation on various systems. Will squash and notify before review.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-4652
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2313
----
commit 78a16cf019c2d0c2b4a2293d6fa68e64100a1de5
Author: joewitt <jo...@apache.org>
Date: 2017-12-03T22:45:03Z
NIFI-4652 updating to latest apache version and updating key maven plugins
----
---
[GitHub] nifi pull request #2313: NIFI-4652 updating to latest apache version and upd...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2313
---
[GitHub] nifi issue #2313: NIFI-4652 updating to latest apache version and updating k...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2313
Will review...
---
[GitHub] nifi issue #2313: NIFI-4652 updating to latest apache version and updating k...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2313
Thanks @joewitt! This has been merged to master.
---