You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/08/22 12:42:29 UTC
Review Request 61811: Flattened continuation chains in containerizer
for readability.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61811/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 5772421c3078d36225b946a5286b8c1bf2f007e8
Diff: https://reviews.apache.org/r/61811/diff/1/
Testing
-------
make check on:
`Apple LLVM version 8.0.0 (clang-800.0.42.1)` on Mac OS 10.11.6
`c++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)` on Fedora 24
Thanks,
Alexander Rukletsov
Re: Review Request 61811: Flattened continuation chains in
containerizer for readability.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61811/#review183468
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61811]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 22, 2017, 2:42 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61811/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 2:42 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 5772421c3078d36225b946a5286b8c1bf2f007e8
>
>
> Diff: https://reviews.apache.org/r/61811/diff/1/
>
>
> Testing
> -------
>
> make check on:
> `Apple LLVM version 8.0.0 (clang-800.0.42.1)` on Mac OS 10.11.6
> `c++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)` on Fedora 24
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61811: Flattened continuation chains in
containerizer for readability.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61811/
-----------------------------------------------------------
(Updated Aug. 22, 2017, 5:17 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp 5772421c3078d36225b946a5286b8c1bf2f007e8
Diff: https://reviews.apache.org/r/61811/diff/2/
Changes: https://reviews.apache.org/r/61811/diff/1-2/
Testing
-------
make check on:
`Apple LLVM version 8.0.0 (clang-800.0.42.1)` on Mac OS 10.11.6
`c++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)` on Fedora 24
Thanks,
Alexander Rukletsov