You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Andras Bokor (JIRA)" <ji...@apache.org> on 2017/05/11 19:16:04 UTC

[jira] [Created] (HDFS-11810) Calling maven-site-plugin directly for docs profile is unnecessary

Andras Bokor created HDFS-11810:
-----------------------------------

             Summary: Calling maven-site-plugin directly for docs profile is unnecessary
                 Key: HDFS-11810
                 URL: https://issues.apache.org/jira/browse/HDFS-11810
             Project: Hadoop HDFS
          Issue Type: Bug
            Reporter: Andras Bokor
            Assignee: Andras Bokor
            Priority: Minor


For a few modules:
* hadoop-auth
* hadoop-kms
* hadoop-hdfs-httpfs
* hadoop-sls

we call {{mave-site-plugin}} directly when docs profile is active.
In main pom we use {{excludeDefaults}} in reporting section and allow only javadoc and dependency-plugin for the report. Since javadoc plugin is set to {{inherited}} false it won't be called on individual child modules. So actually {{maven-dependency-plugin:analyze-report}} is the only additional goal which will run.
I debugged the process with {{mvn clean package -DskipTests -Dmaven.javadoc.skip=true -DskipShade -Pdocs -X}} command and in all the 4 affected modules I found the following configuration for site plugin:
{code}<reportPlugins>
    <reportPlugin>
      <groupId>org.apache.maven.plugins</groupId>
      <artifactId>maven-dependency-plugin</artifactId>
      <version>2.10</version>
      <reportSets>
        <reportSet>
          <id>default</id>
          <reports>
            <report>analyze-report</report>
          </reports>
        </reportSet>
      </reportSets>
    </reportPlugin>
  </reportPlugins>{code}

At this point I do not see the purpose of calling {{mave-site-plugin}} for docs profile. It does not contain useful information. Or if it does why don't we call for other modules? It's inconsistent.
Considering to remove.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org