[GitHub] [kafka] jasonyanwenl edited a comment on pull request #11241: KAFKA-13032: add NPE checker for KeyValueMapper

[GitBox <gi...@apache.org>]

jasonyanwenl edited a comment on pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#issuecomment-905975169


   > Thanks for the PR @jasonyanwenl !
   > 
   > Here my feedback!
   > 
   > I think we should consider to introduce a specific exception for exceptions that originate from user code. Such exceptions could be distinguished from other exceptions when caught in the [Streams uncaught exception handler](https://kafka.apache.org/28/javadoc/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.html) and better reacted upon.
   > 
   > Adding such an exception would require a KIP. Are you interested?
   
   Hi @cadonna, thanks for yor feedback. Those are great insights! I'm definitely interested in doing this. But before that, have several questions:
   
   1. Will this be the first case where we have a distiguished exception type for user code error?
   2. Shall we finish this as a simple beginner issue and create a new ticket tracking the design & impl of that? The concern is that this NPE ticket might not be the only place where the new exceptioin could bring benefit and we probably should analyze code to expand the scope and update exception type all at once in a dedicated PR/ticket. Hence I think separating those two is suitable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org