You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/12 07:39:33 UTC

[GitHub] [druid] gianm opened a new pull request #9508: Move RowSignature from druid-sql to druid-processing and make use of it.

gianm opened a new pull request #9508: Move RowSignature from druid-sql to druid-processing and make use of it.
URL: https://github.com/apache/druid/pull/9508
 
 
   I split this out from another patch I'm working on that allows the broker to inline subqueries (see https://github.com/apache/druid/issues/8728). In that patch it became clear that `QueryToolChest#resultArrayFields` really should return type info as well. I started using a `Map<String, ValueType>` for that, as is done in a few other places in the code, but then realized that it would be better to use the RowSignature class from druid-sql. So I moved it into druid-processing in the following way.
   
   This patch will unblock a future subquery inlining patch.
   
   1) Moved (most of) RowSignature from sql to processing. Left behind the SQL-specific
      stuff in a RowSignatures utility class. It also picked up some new convenience
      methods along the way.
   2) There were a lot of places in the code where Map<String, ValueType> was used to
      associate columns with type info. These are now all replaced with RowSignature.
   3) QueryToolChest's resultArrayFields method is replaced with resultArraySignature,
      and it now provides type info.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] fjy merged pull request #9508: Move RowSignature from druid-sql to druid-processing and make use of it.

Posted by GitBox <gi...@apache.org>.
fjy merged pull request #9508: Move RowSignature from druid-sql to druid-processing and make use of it.
URL: https://github.com/apache/druid/pull/9508
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org