You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/29 11:01:22 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
gaoyunhaii opened a new pull request #13841:
URL: https://github.com/apache/flink/pull/13841
## What is the purpose of the change
This PR adds the e2e tests for the new FileSink. In the e2e tests we mainly focus on cases of TaskMangers get killed, thus we only test the streaming mode since for batch mode, in this version the new file sink still not be able to achieve exactly-once if the ResultPartition gets lost. The stream & batch mode for cases of task failover is covered by `FileSinkITCase`.
## Brief change log
- 86e3c5950cf82baa0a5e3078b0c30050f262dcb0 adds the test program and the test scripts.
## Verifying this change
This change is a test for itself.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
}, {
"hash" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9085",
"triggerID" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"triggerType" : "PUSH"
}, {
"hash" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9114",
"triggerID" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"triggerType" : "PUSH"
}, {
"hash" : "ba30909849312f20c9ae3cdf2f3b270195eeaac9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ba30909849312f20c9ae3cdf2f3b270195eeaac9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 62cc0044b2b3ce6d379a7e71ef440949b6a2d577 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9114)
* ba30909849312f20c9ae3cdf2f3b270195eeaac9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86e3c5950cf82baa0a5e3078b0c30050f262dcb0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-722312491
I would also second @aljoscha 's opinion if this is possible. If I recall correctly it is using the `OnCheckpointPolicy` so it does not need processing time support. But we have to check again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-722319814
Very thanks for the review! The initial thought is that we might need also support batch mode in the future, which would change the scripts and test program, but I also agree with that it would be better to reuse the current codes to decrease the duplication until they diverge. I'll modify the PR to reuse the existing test~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-722309423
Instead of copying the `test_streaming_file_sink.sh`, could we just parameterize that existing test with the test program jar? And maybe rename it to `test_file_sink.sh`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii closed pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #13841:
URL: https://github.com/apache/flink/pull/13841
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
}, {
"hash" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9085",
"triggerID" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86e3c5950cf82baa0a5e3078b0c30050f262dcb0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596)
* 87f6e430069483ef43e4bf1d25a3164a9975db36 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9085)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
}, {
"hash" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9085",
"triggerID" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"triggerType" : "PUSH"
}, {
"hash" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9114",
"triggerID" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"triggerType" : "PUSH"
}, {
"hash" : "ba30909849312f20c9ae3cdf2f3b270195eeaac9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9130",
"triggerID" : "ba30909849312f20c9ae3cdf2f3b270195eeaac9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ba30909849312f20c9ae3cdf2f3b270195eeaac9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9130)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86e3c5950cf82baa0a5e3078b0c30050f262dcb0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
}, {
"hash" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9085",
"triggerID" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"triggerType" : "PUSH"
}, {
"hash" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87f6e430069483ef43e4bf1d25a3164a9975db36 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9085)
* 62cc0044b2b3ce6d379a7e71ef440949b6a2d577 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
}, {
"hash" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9085",
"triggerID" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"triggerType" : "PUSH"
}, {
"hash" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9114",
"triggerID" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"triggerType" : "PUSH"
}, {
"hash" : "ba30909849312f20c9ae3cdf2f3b270195eeaac9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9130",
"triggerID" : "ba30909849312f20c9ae3cdf2f3b270195eeaac9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 62cc0044b2b3ce6d379a7e71ef440949b6a2d577 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9114)
* ba30909849312f20c9ae3cdf2f3b270195eeaac9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9130)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
}, {
"hash" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86e3c5950cf82baa0a5e3078b0c30050f262dcb0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596)
* 87f6e430069483ef43e4bf1d25a3164a9975db36 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
}, {
"hash" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9085",
"triggerID" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"triggerType" : "PUSH"
}, {
"hash" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9114",
"triggerID" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"triggerType" : "PUSH"
}, {
"hash" : "ba30909849312f20c9ae3cdf2f3b270195eeaac9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9130",
"triggerID" : "ba30909849312f20c9ae3cdf2f3b270195eeaac9",
"triggerType" : "PUSH"
}, {
"hash" : "06c9fd31fa9645ccd934bddcc84698724296589b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "06c9fd31fa9645ccd934bddcc84698724296589b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ba30909849312f20c9ae3cdf2f3b270195eeaac9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9130)
* 06c9fd31fa9645ccd934bddcc84698724296589b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-723078640
Merged!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
}, {
"hash" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9085",
"triggerID" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"triggerType" : "PUSH"
}, {
"hash" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9114",
"triggerID" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"triggerType" : "PUSH"
}, {
"hash" : "ba30909849312f20c9ae3cdf2f3b270195eeaac9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9130",
"triggerID" : "ba30909849312f20c9ae3cdf2f3b270195eeaac9",
"triggerType" : "PUSH"
}, {
"hash" : "06c9fd31fa9645ccd934bddcc84698724296589b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9147",
"triggerID" : "06c9fd31fa9645ccd934bddcc84698724296589b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ba30909849312f20c9ae3cdf2f3b270195eeaac9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9130)
* 06c9fd31fa9645ccd934bddcc84698724296589b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9147)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
}, {
"hash" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9085",
"triggerID" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"triggerType" : "PUSH"
}, {
"hash" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9114",
"triggerID" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 62cc0044b2b3ce6d379a7e71ef440949b6a2d577 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9114)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha closed pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #13841:
URL: https://github.com/apache/flink/pull/13841
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86e3c5950cf82baa0a5e3078b0c30050f262dcb0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718698511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8596",
"triggerID" : "86e3c5950cf82baa0a5e3078b0c30050f262dcb0",
"triggerType" : "PUSH"
}, {
"hash" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9085",
"triggerID" : "87f6e430069483ef43e4bf1d25a3164a9975db36",
"triggerType" : "PUSH"
}, {
"hash" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9114",
"triggerID" : "62cc0044b2b3ce6d379a7e71ef440949b6a2d577",
"triggerType" : "PUSH"
}, {
"hash" : "ba30909849312f20c9ae3cdf2f3b270195eeaac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9130",
"triggerID" : "ba30909849312f20c9ae3cdf2f3b270195eeaac9",
"triggerType" : "PUSH"
}, {
"hash" : "06c9fd31fa9645ccd934bddcc84698724296589b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9147",
"triggerID" : "06c9fd31fa9645ccd934bddcc84698724296589b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 06c9fd31fa9645ccd934bddcc84698724296589b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9147)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-723207791
I reverted the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-723198709
Note: This PR has been merged despite a build failure, which now permanently breaks build on master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13841: [FLINK-19850] Add e2e tests for the new File Sink in the streaming mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13841:
URL: https://github.com/apache/flink/pull/13841#issuecomment-718663912
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 86e3c5950cf82baa0a5e3078b0c30050f262dcb0 (Thu Oct 29 11:04:08 UTC 2020)
**Warnings:**
* **6 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org