You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/08/26 00:29:45 UTC
[jira] [Commented] (CB-9542) Browser Proxy not defined correctly
[ https://issues.apache.org/jira/browse/CB-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712084#comment-14712084 ]
ASF GitHub Bot commented on CB-9542:
------------------------------------
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/31
CB-9542 Browser Proxy not defined correctly
Redefined to actually use the proxy instead of overwriting(clobbers) the initial implementation.
Verified online/offline events fire.
Changed plugin.xml windows/windows8 to use 'runs' instead of incorrect merges.target=""
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-plugin-network-information CB-9542
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-network-information/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit cae65dd093d6c37965b913dddd8a282d8b94614f
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2015-08-25T22:23:44Z
CB-9542 Browser Proxy not defined correctly
----
> Browser Proxy not defined correctly
> -----------------------------------
>
> Key: CB-9542
> URL: https://issues.apache.org/jira/browse/CB-9542
> Project: Apache Cordova
> Issue Type: Bug
> Components: Browser, Plugin Network Information
> Reporter: Jesse MacFadyen
> Assignee: Jesse MacFadyen
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org