You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Martijn Hendriks (JIRA)" <ji...@apache.org> on 2010/01/20 10:54:03 UTC

[jira] Commented: (JCR-2449) Slow performance due to JCR-2138 (Prevent persistence of faulty back-references)

    [ https://issues.apache.org/jira/browse/JCR-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802772#action_12802772 ] 

Martijn Hendriks commented on JCR-2449:
---------------------------------------

The problem did not specifically involve clustered environments. I wrote the ReferencesTest that has been added in JCR-2138; running these against the jackrabbit-1.4.5 gives 5 test failures because of corrupt references. This happens when two sessions add/modify the same reference property at the same time.

Your patch effectively removes the patch for JCR-2138 and the ReferencesTest does not fail. That's good! Something in the ItemStateManager hierarchy must have changed such that the problem cannot occur anymore.

> Slow performance due to JCR-2138 (Prevent persistence of faulty back-references)
> --------------------------------------------------------------------------------
>
>                 Key: JCR-2449
>                 URL: https://issues.apache.org/jira/browse/JCR-2449
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 1.5.7, 2.0-beta4
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>             Fix For: 2.0.0
>
>         Attachments: JCR-2449.patch
>
>
> In revision 782898, the following code was introduced:
> updateReferences() {
>     for (Iterator i = local.addedStates(); i.hasNext();) {
>         ...
>         if (hasItemState(state.getId())) {
>             ...
>         }
>     }
> }
> This will try to fetch inexistent nodes from the persistence manager.
> Depending on the persistence manager implementation, this is very slow.
> I hope there is a way to avoid this call, or if not, speed it up.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.