You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2018/09/28 22:46:22 UTC

Review Request 68878: Export-Import Audit Display: Sorting

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68878/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj and Sarath Subramanian.


Bugs: ATLAS-2902
    https://issues.apache.org/jira/browse/ATLAS-2902


Repository: atlas


Description
-------

**Approach**

- Based on _startTime_.


Diffs
-----

  intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java d6b0ede2b 
  repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java d433c2afc 
  repository/src/test/java/org/apache/atlas/repository/impexp/ZipSourceTest.java f0034fac7 


Diff: https://reviews.apache.org/r/68878/diff/1/


Testing
-------

**Unit tests**
Existing tests.

**Functional tests**
Via web ui.


Thanks,

Ashutosh Mestry


Re: Review Request 68878: Export-Import Audit Display: Sorting

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68878/#review209158
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java
Lines 104 (patched)
<https://reviews.apache.org/r/68878/#comment293451>

    Consider sorting search results in Solr instead of sorting in-memory?


- Sarath Subramanian


On Sept. 28, 2018, 3:46 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68878/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2018, 3:46 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2902
>     https://issues.apache.org/jira/browse/ATLAS-2902
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> 
> - Based on _startTime_.
> 
> 
> Diffs
> -----
> 
>   intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java d6b0ede2b 
>   repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java d433c2afc 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ZipSourceTest.java f0034fac7 
> 
> 
> Diff: https://reviews.apache.org/r/68878/diff/1/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> Existing tests.
> 
> **Functional tests**
> Via web ui.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>