You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/06 01:09:56 UTC
[GitHub] [airflow] mik-laj opened a new pull request #7070: [AIRFLOW-6480]
Hide kerberos command if kerberos is disabled
mik-laj opened a new pull request #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070
Similar to: https://github.com/apache/airflow/pull/6877
Most users do not use Kerberos, so this command will not work.
---
Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6480
- [X] Description above provides context of the change
- [X] Commit message starts with `[AIRFLOW-NNNN]`, where AIRFLOW-NNNN = JIRA ID*
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
(*) For document-only changes, no JIRA issue is needed. Commit message starts `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #7070: [AIRFLOW-6480]
Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-571095528
> I would say let's not do it, I don't see much benefits of it.
>
> The CLI command should be static and it might cause issues when building docs too and might cause issue for the CLI Autocomplete too.
It's already done for celery. @mik-laj have you observed any problems?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj closed pull request #7070: [AIRFLOW-6480] Hide
kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
mik-laj closed pull request #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7070: [AIRFLOW-6480] Hide
kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-571153476
Aah make sense, but I am still not entirely sure on the benfits of it. In my opinion the CLI should show all the commands and should be same for all users.
The commands should then handle the errors when a config is enabled/disabled.
Happy to hear thoughts from others too @potiuk @ashb ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7070: [AIRFLOW-6480] Hide
kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-571149132
I have not observed any problems. Documentation is building properly. We have a special condition to support it
https://github.com/apache/airflow/pull/7070/files#diff-1c2404a3a60f829127232842250ff406R1008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7070: [AIRFLOW-6480] Hide
kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-574827584
I thought about this topic and will prepare a second PR that will disable hiding commands for Celery Executor. Thanks for the discussion!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil edited a comment on issue #7070: [AIRFLOW-6480]
Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570976842
I would say let's not do it, I don't see much benefits of it.
The CLI command should be static and it might cause issues when building docs too and might cause issue for the CLI Autocomplete too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7070: [AIRFLOW-6480] Hide
kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-571239159
> The main benefit is to improve the user experience. Many companies do not use Kerberos, but this option appears on the user screen. This can confuse new users because they don't know what Kerberos is and whether they should use it. However, if the company decides to use Kerberos, then the option is still available, and people should be aware of it. We have win-win situations because new users can use Airflow more easily, and current users can still use this feature. In my opinion, we should not think of Airflow CLI as a utils application that performs one function, e.g. CURL. But as a complex application that is used in everyday work. Some users install Airflow locally and use CLI in their daily work. In the next step, they upload files to the production server.
>
> In my opinion, we should split CLI into two parts:
>
> * one intended for normal users
> * one for administrators
>
> The administrator would be able to run Kerberos. The user would not have this command. Unfortunately, it will be very difficult to do now, but...in the future, after we create the API, we can go back to this topic. Currently, this is the best way to improve the experience for a normal user
I definitely don't have a strong opinion **against** it :) but I just feel that there is no much to gain
So happy to get it merged if others agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7070: [AIRFLOW-6480] Hide
kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-571242909
I think it's very rare thing to hide some command line options. I do not know a single POSIX-compliant tool that does it. @mik-laj - do you have an example of a tool that does something similar.
It's not super strong opinion, but I would prefer to keep it unchanged.
For one I often check what options are available by running "tool" --help and reading through. And in this case I might not even be aware that I can configure kerberos. Of course "one should read the docs", but help printed by the CLI is also a documentation. I often don't go looking elsewhere if I do not find something in the --help output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7070: [AIRFLOW-6480] Hide
kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570976842
I would say let's not do it, I don't see much benefits of it.
The CLI command should be static and it might cause issues when building docs too .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **increase** coverage by `74.64%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
===========================================
+ Coverage 10.08% 84.72% +74.64%
===========================================
Files 679 680 +1
Lines 38735 38750 +15
===========================================
+ Hits 3906 32831 +28925
+ Misses 34829 5919 -28910
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (+93.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `90.38% <0%> (+3.84%)` | :arrow_up: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (+5.88%)` | :arrow_up: |
| ... and [605 more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk edited a comment on issue #7070: [AIRFLOW-6480]
Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-571242909
I think it's very rare thing to hide some command line options. I do not know a single POSIX-compliant tool that does it. @mik-laj - do you have an example of a tool that does something similar?
It's not super strong opinion, but I would prefer to keep it unchanged.
For one I often check what options are available by running "tool" --help and reading through. And in this case I might not even be aware that I can configure kerberos. Of course "one should read the docs", but help printed by the CLI is also a documentation. I often don't go looking elsewhere if I do not find something in the --help output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7070: [AIRFLOW-6480] Hide
kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7070:
[AIRFLOW-6480] Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=h1) Report
> Merging [#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7070 +/- ##
==========================================
- Coverage 84.97% 84.72% -0.26%
==========================================
Files 679 680 +1
Lines 38664 38750 +86
==========================================
- Hits 32856 32831 -25
- Misses 5808 5919 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `93.02% <50%> (-1.03%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=footer). Last update [2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7070: [AIRFLOW-6480] Hide
kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-571162170
The main benefit is to improve the user experience. Many companies do not use Kerberos, but this option appears on the user screen. This can confuse new users because they don't know what Kerberos is and whether they should use it. However, if the company decides to use Kerberos, then the option is still available, and people should be aware of it. We have win-win situations because new users can use Airflow more easily, and current users can still use this feature. In my opinion, we should not think of Airflow CLI as a utils application that performs one function, e.g. CURL. But as a complex application that is used in everyday work. Some users install Airflow locally and use CLI in their daily work. In the next step, they upload files to the production server.
In my opinion, we should split CLI into two parts:
* one intended for normal users
* one for administrators
The administrator would be able to run Kerberos. The user would not have this command. Unfortunately, it will be very difficult to do now, but...in the future, after we create the API, we can go back to this topic. Currently, this is the best way to improve the experience for a normal user
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil edited a comment on issue #7070: [AIRFLOW-6480]
Hide kerberos command if kerberos is disabled
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-571153476
Aah make sense, but I am still not entirely sure on the benfits of it. In my opinion the CLI should show all the commands and should be same for all users.
The commands should then handle the errors when a config is enabled/disabled.
Happy to hear thoughts from others too @potiuk @ashb ?
PS: I am not against it but just want to know the benefits of it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services