You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "Karthi1711 (via GitHub)" <gi...@apache.org> on 2023/03/13 17:50:45 UTC

[I] Request to expose certain protected APIs as public (logging-log4j2)

Karthi1711 opened a new issue, #1365:
URL: https://github.com/apache/logging-log4j2/issues/1365

   Hello,
   
   I would like to request that certain APIs which are currently protected be exposed as public for broader access. Specifically, I am interested in accessing `createCompressAction()`, `getExtension()`, `length()` in `FileExtension` enum for customized rollover strategy which we have written at our end. 
   
   Could you please consider this request and let me know if it is possible to make these APIs public? I would be happy to provide more information or answer any questions you may have.
   
   Thank you for your time and consideration.
   
   Best regards,
   Karthi


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on issue #1365:
URL: https://github.com/apache/logging-log4j2/issues/1365#issuecomment-1757095162

   @garydgregory, I see the points you raise. We already expect users to implement `RolloverStrategy`s, which is a public interface. In *all* of our own implementations of `RolloverStrategy`, we reach out to `FileExtension` methods the user is requesting to expose. Hence, I find it fair that custom `RolloverStrategy`s should have access to those methods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on issue #1365:
URL: https://github.com/apache/logging-log4j2/issues/1365#issuecomment-1466908995

   I think we want to be careful here @ppkarwasz: Do we really want to lock down an API as public for such low level classes and be bound to binary compatibility? Or are we going to say this class is not part of BC?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy closed issue #1365: Request to expose certain protected APIs as public
URL: https://github.com/apache/logging-log4j2/issues/1365


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

Posted by "Karthi1711 (via GitHub)" <gi...@apache.org>.
Karthi1711 commented on issue #1365:
URL: https://github.com/apache/logging-log4j2/issues/1365#issuecomment-1671070784

   PR created: https://github.com/apache/logging-log4j2/pull/1683.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on issue #1365:
URL: https://github.com/apache/logging-log4j2/issues/1365#issuecomment-1466986286

   @garydgregory,
   
   I would just prefer to see this request in the form of a PR, that we can discuss on the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on issue #1365:
URL: https://github.com/apache/logging-log4j2/issues/1365#issuecomment-1466706309

   Hello @Karthi1711,
   
   Can You submit a PR with the changes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org