[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #11796: solve the OrderedServicesCache concurrency exception

[GitBox <gi...@apache.org>]

strongduanmu commented on a change in pull request #11796:
URL: https://github.com/apache/shardingsphere/pull/11796#discussion_r688271265



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/spi/ordered/OrderedSPIRegistry.java
##########
@@ -77,18 +77,18 @@
      * @param comparator comparator
      * @return registered services
      */
-    @SuppressWarnings("unchecked")
     public static <K, V extends OrderedSPI<?>> Map<K, V> getRegisteredServices(final Collection<K> types, final Class<V> orderedSPIClass, final Comparator<Integer> comparator) {

Review comment:
       > Is it better to adjust the param sequence too?
   > `orderedSPIClass` maybe the first param, `types` is second one.
   
   @terrymanu Yes, it is better to understand. I will optimize it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org