You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by Rob Vesse <rv...@yarcdata.com> on 2013/06/28 20:27:38 UTC
Re: Jetty Upgrade [was svn commit: r1488601 -
/jena/trunk/jena-fuseki/src/test/java/org/apache/jena/fuseki/ServerTest.java]
Re: the LoginService print that appears to be another spurious print
statement direct to stdout coming from Jetty
A quick review of the source for Jetty 9 suggests it does not have this.
Should we consider bumping Fuseki to use Jetty 9 in the near future?
Rob
On 6/27/13 12:50 PM, "Rob Vesse" <rv...@cray.com> wrote:
>
>
>On 6/27/13 12:43 PM, "Andy Seaborne" <an...@apache.org> wrote:
>
>>On 26/06/13 11:42, Andy Seaborne wrote:
>>> On 26/06/13 00:07, Rob Vesse wrote:
>>>> Can this commit be rolled back in some way?
>>>
>>> Sure - seems reasonable.
>>>
>>> Might be a good it as graceful server shutdown, which includes
>>> deregistration of datasets.
>>>
>>> I'll take a look ASAP.
>>>
>>> JENA-478
>>>
>>>> It hampers test isolation because the server isn't a unique instance
>>>>each
>>>> time. Would a better fix not be to deregister JMX in the stopServer()
>>>> method?
>>
>>Rob -
>>
>>Looking at ARQMgt, JMX beans get deregistered if they are already
>>registered so (1) this is broken or (2) some thing else is going on.
>
>Ok I will look into this once I get past the other thing I'm working on
>right now (JENA-480)
>
>
>>
>>The only issue I can see is that ServerTest has a class static
>>setupServer() ; which creates an initial server that hangs around. If I
>>remove that, servers start and stop according to the test class.
>>Usually that's
>>
>> @BeforeClass public static void beforeClass()
>> { ServerTest.allocServer() ; }
>>
>> @AfterClass public static void afterClass()
>> { ServerTest.freeServer() ; }
>>
>> @Before public void before()
>> { ServerTest.resetServer() ; }
>>
>>but you could @before/@after for each test. Server setup is not fast.
>>
>> Andy
>>
>>Something somewhere is printing to stderr:
>>
>>LoginService=HashLoginService[Fuseki Authentication]
>>identityService=org.eclipse.jetty.security.DefaultIdentityService@33c4bcd
>>a
>>
>>This may be jetty - an upgrade of versions may fix there. There were a
>>few of these in a recent version.
>
>That comes from the new tests I added that use the new feature I added of
>enabling Jetty basic auth programmatically. I will look at how to
>suppress that.
>
>Rob
>
>>
>> Andy
>
Re: Jetty Upgrade [was svn commit: r1488601 -
/jena/trunk/jena-fuseki/src/test/java/org/apache/jena/fuseki/ServerTest.java]
Posted by Rob Vesse <rv...@yarcdata.com>.
Version 9 has some breaking API changes, I did try to compile with it
briefly and got a bunch of errors hence why I started this thread.
Off the top of my head the main differences were:
MimeTypes.CONSTANTS -> MimeTypes.Types.CONSTANTS (may not be exact -
essentially constants had moved to an enum)
AbstractHttpConnection -> AbstractConnection
There may have been others but those were the main ones that failed in
compilation.
When we go to Version 9 we should probably do a major version bump to
Fuseki
Rob
On 7/1/13 1:30 AM, "Andy Seaborne" <an...@apache.org> wrote:
>On 28/06/13 20:41, Andy Seaborne wrote:
>> On 28/06/13 19:27, Rob Vesse wrote:
>>> Re: the LoginService print that appears to be another spurious print
>>> statement direct to stdout coming from Jetty
>>>
>>> A quick review of the source for Jetty 9 suggests it does not have
>>>this.
>>> Should we consider bumping Fuseki to use Jetty 9 in the near future?
>>>
>>> Rob
>>
>> Can do - or what about the latest 8.1 series?
>>
>> 8.1.11.v20130520
>>
>> Or 8.1.11 now and 9 soon.
>>
>> Andy
>
>I bumped Fuseki to 8.1.11 as it should be "just" fixes. Not noisy any
>more.
>
>Shall we switch to 9.0.4.mumble?
>
> Andy
>
>
>
>>
>>>
>>>
>>> On 6/27/13 12:50 PM, "Rob Vesse" <rv...@cray.com> wrote:
>>>
>>>>
>>>>
>>>> On 6/27/13 12:43 PM, "Andy Seaborne" <an...@apache.org> wrote:
>>>>
>>>>> On 26/06/13 11:42, Andy Seaborne wrote:
>>>>>> On 26/06/13 00:07, Rob Vesse wrote:
>>>>>>> Can this commit be rolled back in some way?
>>>>>>
>>>>>> Sure - seems reasonable.
>>>>>>
>>>>>> Might be a good it as graceful server shutdown, which includes
>>>>>> deregistration of datasets.
>>>>>>
>>>>>> I'll take a look ASAP.
>>>>>>
>>>>>> JENA-478
>>>>>>
>>>>>>> It hampers test isolation because the server isn't a unique
>>>>>>>instance
>>>>>>> each
>>>>>>> time. Would a better fix not be to deregister JMX in the
>>>>>>> stopServer()
>>>>>>> method?
>>>>>
>>>>> Rob -
>>>>>
>>>>> Looking at ARQMgt, JMX beans get deregistered if they are already
>>>>> registered so (1) this is broken or (2) some thing else is going on.
>>>>
>>>> Ok I will look into this once I get past the other thing I'm working
>>>>on
>>>> right now (JENA-480)
>>>>
>>>>
>>>>>
>>>>> The only issue I can see is that ServerTest has a class static
>>>>> setupServer() ; which creates an initial server that hangs around.
>>>>> If I
>>>>> remove that, servers start and stop according to the test class.
>>>>> Usually that's
>>>>>
>>>>> @BeforeClass public static void beforeClass()
>>>>> { ServerTest.allocServer() ; }
>>>>>
>>>>> @AfterClass public static void afterClass()
>>>>> { ServerTest.freeServer() ; }
>>>>>
>>>>> @Before public void before()
>>>>> { ServerTest.resetServer() ; }
>>>>>
>>>>> but you could @before/@after for each test. Server setup is not
>>>>>fast.
>>>>>
>>>>> Andy
>>>>>
>>>>> Something somewhere is printing to stderr:
>>>>>
>>>>> LoginService=HashLoginService[Fuseki Authentication]
>>>>>
>>>>>identityService=org.eclipse.jetty.security.DefaultIdentityService@33c4
>>>>>bcd
>>>>>
>>>>> a
>>>>>
>>>>> This may be jetty - an upgrade of versions may fix there. There
>>>>>were a
>>>>> few of these in a recent version.
>>>>
>>>> That comes from the new tests I added that use the new feature I
>>>> added of
>>>> enabling Jetty basic auth programmatically. I will look at how to
>>>> suppress that.
>>>>
>>>> Rob
>>>>
>>>>>
>>>>> Andy
>>>>
>>>
>>
>
Re: Jetty Upgrade [was svn commit: r1488601 - /jena/trunk/jena-fuseki/src/test/java/org/apache/jena/fuseki/ServerTest.java]
Posted by Andy Seaborne <an...@apache.org>.
On 28/06/13 20:41, Andy Seaborne wrote:
> On 28/06/13 19:27, Rob Vesse wrote:
>> Re: the LoginService print that appears to be another spurious print
>> statement direct to stdout coming from Jetty
>>
>> A quick review of the source for Jetty 9 suggests it does not have this.
>> Should we consider bumping Fuseki to use Jetty 9 in the near future?
>>
>> Rob
>
> Can do - or what about the latest 8.1 series?
>
> 8.1.11.v20130520
>
> Or 8.1.11 now and 9 soon.
>
> Andy
I bumped Fuseki to 8.1.11 as it should be "just" fixes. Not noisy any more.
Shall we switch to 9.0.4.mumble?
Andy
>
>>
>>
>> On 6/27/13 12:50 PM, "Rob Vesse" <rv...@cray.com> wrote:
>>
>>>
>>>
>>> On 6/27/13 12:43 PM, "Andy Seaborne" <an...@apache.org> wrote:
>>>
>>>> On 26/06/13 11:42, Andy Seaborne wrote:
>>>>> On 26/06/13 00:07, Rob Vesse wrote:
>>>>>> Can this commit be rolled back in some way?
>>>>>
>>>>> Sure - seems reasonable.
>>>>>
>>>>> Might be a good it as graceful server shutdown, which includes
>>>>> deregistration of datasets.
>>>>>
>>>>> I'll take a look ASAP.
>>>>>
>>>>> JENA-478
>>>>>
>>>>>> It hampers test isolation because the server isn't a unique instance
>>>>>> each
>>>>>> time. Would a better fix not be to deregister JMX in the
>>>>>> stopServer()
>>>>>> method?
>>>>
>>>> Rob -
>>>>
>>>> Looking at ARQMgt, JMX beans get deregistered if they are already
>>>> registered so (1) this is broken or (2) some thing else is going on.
>>>
>>> Ok I will look into this once I get past the other thing I'm working on
>>> right now (JENA-480)
>>>
>>>
>>>>
>>>> The only issue I can see is that ServerTest has a class static
>>>> setupServer() ; which creates an initial server that hangs around.
>>>> If I
>>>> remove that, servers start and stop according to the test class.
>>>> Usually that's
>>>>
>>>> @BeforeClass public static void beforeClass()
>>>> { ServerTest.allocServer() ; }
>>>>
>>>> @AfterClass public static void afterClass()
>>>> { ServerTest.freeServer() ; }
>>>>
>>>> @Before public void before()
>>>> { ServerTest.resetServer() ; }
>>>>
>>>> but you could @before/@after for each test. Server setup is not fast.
>>>>
>>>> Andy
>>>>
>>>> Something somewhere is printing to stderr:
>>>>
>>>> LoginService=HashLoginService[Fuseki Authentication]
>>>> identityService=org.eclipse.jetty.security.DefaultIdentityService@33c4bcd
>>>>
>>>> a
>>>>
>>>> This may be jetty - an upgrade of versions may fix there. There were a
>>>> few of these in a recent version.
>>>
>>> That comes from the new tests I added that use the new feature I
>>> added of
>>> enabling Jetty basic auth programmatically. I will look at how to
>>> suppress that.
>>>
>>> Rob
>>>
>>>>
>>>> Andy
>>>
>>
>
Re: Jetty Upgrade [was svn commit: r1488601 - /jena/trunk/jena-fuseki/src/test/java/org/apache/jena/fuseki/ServerTest.java]
Posted by Andy Seaborne <an...@apache.org>.
On 28/06/13 19:27, Rob Vesse wrote:
> Re: the LoginService print that appears to be another spurious print
> statement direct to stdout coming from Jetty
>
> A quick review of the source for Jetty 9 suggests it does not have this.
> Should we consider bumping Fuseki to use Jetty 9 in the near future?
>
> Rob
Can do - or what about the latest 8.1 series?
8.1.11.v20130520
Or 8.1.11 now and 9 soon.
Andy
>
>
> On 6/27/13 12:50 PM, "Rob Vesse" <rv...@cray.com> wrote:
>
>>
>>
>> On 6/27/13 12:43 PM, "Andy Seaborne" <an...@apache.org> wrote:
>>
>>> On 26/06/13 11:42, Andy Seaborne wrote:
>>>> On 26/06/13 00:07, Rob Vesse wrote:
>>>>> Can this commit be rolled back in some way?
>>>>
>>>> Sure - seems reasonable.
>>>>
>>>> Might be a good it as graceful server shutdown, which includes
>>>> deregistration of datasets.
>>>>
>>>> I'll take a look ASAP.
>>>>
>>>> JENA-478
>>>>
>>>>> It hampers test isolation because the server isn't a unique instance
>>>>> each
>>>>> time. Would a better fix not be to deregister JMX in the stopServer()
>>>>> method?
>>>
>>> Rob -
>>>
>>> Looking at ARQMgt, JMX beans get deregistered if they are already
>>> registered so (1) this is broken or (2) some thing else is going on.
>>
>> Ok I will look into this once I get past the other thing I'm working on
>> right now (JENA-480)
>>
>>
>>>
>>> The only issue I can see is that ServerTest has a class static
>>> setupServer() ; which creates an initial server that hangs around. If I
>>> remove that, servers start and stop according to the test class.
>>> Usually that's
>>>
>>> @BeforeClass public static void beforeClass()
>>> { ServerTest.allocServer() ; }
>>>
>>> @AfterClass public static void afterClass()
>>> { ServerTest.freeServer() ; }
>>>
>>> @Before public void before()
>>> { ServerTest.resetServer() ; }
>>>
>>> but you could @before/@after for each test. Server setup is not fast.
>>>
>>> Andy
>>>
>>> Something somewhere is printing to stderr:
>>>
>>> LoginService=HashLoginService[Fuseki Authentication]
>>> identityService=org.eclipse.jetty.security.DefaultIdentityService@33c4bcd
>>> a
>>>
>>> This may be jetty - an upgrade of versions may fix there. There were a
>>> few of these in a recent version.
>>
>> That comes from the new tests I added that use the new feature I added of
>> enabling Jetty basic auth programmatically. I will look at how to
>> suppress that.
>>
>> Rob
>>
>>>
>>> Andy
>>
>