[GitHub] [kafka] showuon commented on a change in pull request #11690: KAFKA-13599: Upgrade RocksDB to 6.27.3

[GitBox <gi...@apache.org>]

showuon commented on a change in pull request #11690:
URL: https://github.com/apache/kafka/pull/11690#discussion_r795136975



##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##########
@@ -1662,16 +1673,95 @@ public ConcurrentTaskLimiter compactionThreadLimiter() {
         return columnFamilyOptions.compactionThreadLimiter();
     }
 
+    @Override
     public Options setCompactionFilter(final AbstractCompactionFilter<? extends AbstractSlice<?>> compactionFilter) {
         columnFamilyOptions.setCompactionFilter(compactionFilter);
         return this;
     }
 
+    @Override
     public Options setCompactionFilterFactory(final AbstractCompactionFilterFactory<? extends AbstractCompactionFilter<?>> compactionFilterFactory) {
         columnFamilyOptions.setCompactionFilterFactory(compactionFilterFactory);
         return this;
     }
 
+    @Override
+    public Options setEnableBlobFiles(final boolean enableBlobFiles) {

Review comment:
       Started here, they are options for blobsDB. In the upstream `Options.java`, there are comments at the beginning and the end of the options. Could we add something similar here?
   ```java
    //
     // BEGIN options for blobs (integrated BlobDB)
     //
   ```
   ```java
    //
     // END options for blobs (integrated BlobDB)
     //
   ```
   ref: https://github.com/facebook/rocksdb/blob/main/java/src/main/java/org/rocksdb/Options.java#L1996-L1998
   
   Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org