You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Caleb Rackliffe (Jira)" <ji...@apache.org> on 2020/08/27 22:02:00 UTC
[jira] [Comment Edited] (CASSANDRA-15909) Make Table/Keyspace
Metric Names Consistent With Each Other
[ https://issues.apache.org/jira/browse/CASSANDRA-15909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186122#comment-17186122 ]
Caleb Rackliffe edited comment on CASSANDRA-15909 at 8/27/20, 10:01 PM:
------------------------------------------------------------------------
I've made changes following my own review suggestions and posted a new, rebased version of the patch.
[trunk|https://github.com/apache/cassandra/pull/728], [j8 tests|https://app.circleci.com/pipelines/github/maedhroz/cassandra/98/workflows/d86b8627-c602-44e1-b6d5-cedaa67bc5b8], [j11 tests|https://app.circleci.com/pipelines/github/maedhroz/cassandra/98/workflows/70f8c126-5d86-4e8a-a346-726beb45b87b]
I think the {{ConnectionTest}} failure is a pre-existing issue.
was (Author: maedhroz):
I've made changes following my own review suggestions and posted a new, rebased version of the patch.
[trunk|https://github.com/apache/cassandra/pull/728], [j8 tests|https://app.circleci.com/pipelines/github/maedhroz/cassandra/98/workflows/d86b8627-c602-44e1-b6d5-cedaa67bc5b8], [j11 tests|https://app.circleci.com/pipelines/github/maedhroz/cassandra/98/workflows/70f8c126-5d86-4e8a-a346-726beb45b87b]
> Make Table/Keyspace Metric Names Consistent With Each Other
> -----------------------------------------------------------
>
> Key: CASSANDRA-15909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15909
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
> Reporter: Stephen Mallette
> Assignee: Caleb Rackliffe
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As part of CASSANDRA-15821 it became apparent that certain metric names found in keyspace and tables had different names but were in fact the same metric - they are as follows:
> * Table.SyncTime == Keyspace.RepairSyncTime
> * Table.RepairedDataTrackingOverreadRows == Keyspace.RepairedOverreadRows
> * Table.RepairedDataTrackingOverreadTime == Keyspace.RepairedOverreadTime
> * Table.AllMemtablesHeapSize == Keyspace.AllMemtablesOnHeapDataSize
> * Table.AllMemtablesOffHeapSize == Keyspace.AllMemtablesOffHeapDataSize
> * Table.MemtableOnHeapSize == Keyspace.MemtableOnHeapDataSize
> * Table.MemtableOffHeapSize == Keyspace.MemtableOffHeapDataSize
> Also, client metrics are the only metrics to start with a lower case letter. Change those to upper case to match all the other metrics.
> Unifying this naming would help make metrics more consistent as part of CASSANDRA-15582
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org