You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/02/15 09:35:20 UTC
[GitHub] [bookkeeper] eolivelli opened a new pull request #2265: Revert
"bin/bookkeeper shell supports the -conf"
eolivelli opened a new pull request #2265: Revert "bin/bookkeeper shell supports the -conf"
URL: https://github.com/apache/bookkeeper/pull/2265
This reverts commit 163db4496d50cae198b80c9d88c14579f6d2e9f3.
Descriptions of the changes in this PR:
Commit 163db4496d50cae198b80c9d88c14579f6d2e9f3 broke "bookkeeper shell" command and integration tests are no more able to work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2265: Revert
"bin/bookkeeper shell supports the -conf"
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2265: Revert "bin/bookkeeper shell supports the -conf"
URL: https://github.com/apache/bookkeeper/pull/2265#issuecomment-586684222
ignore ci
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2265: Revert
"bin/bookkeeper shell supports the -conf"
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2265: Revert "bin/bookkeeper shell supports the -conf"
URL: https://github.com/apache/bookkeeper/pull/2265#issuecomment-586600188
Test failure
[ERROR] testGetEntryLogsSet(org.apache.bookkeeper.bookie.TestEntryLog) Time elapsed: 0.015 s <<< FAILURE!
java.lang.AssertionError: expected:<[0, 1]> but was:<[0]>
at org.apache.bookkeeper.bookie.TestEntryLog.testGetEntryLogsSet(TestEntryLog.java:442)
is not related to this patch, it is the second CI breaker.
I would like to commit this patch and then move forward with fixing TestEntryLog
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli merged pull request #2265: Revert
"bin/bookkeeper shell supports the -conf"
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2265: Revert "bin/bookkeeper shell supports the -conf"
URL: https://github.com/apache/bookkeeper/pull/2265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2265: Revert
"bin/bookkeeper shell supports the -conf"
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2265: Revert "bin/bookkeeper shell supports the -conf"
URL: https://github.com/apache/bookkeeper/pull/2265#issuecomment-586616003
This is the link to the flaky test issue
https://github.com/apache/bookkeeper/issues/2260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2265: Revert
"bin/bookkeeper shell supports the -conf"
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2265: Revert "bin/bookkeeper shell supports the -conf"
URL: https://github.com/apache/bookkeeper/pull/2265#issuecomment-586579122
@sijie I am going to merge this change, it is a straight revert of
https://github.com/apache/bookkeeper/pull/2211
I have added comments to #2211
With this change we will be able to validate incoming contributions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services