[GitHub] [geode] jchen21 commented on a diff in pull request #7529: GEODE-10203: SerialVersionUID added.

[GitBox <gi...@apache.org>]

jchen21 commented on code in PR #7529:
URL: https://github.com/apache/geode/pull/7529#discussion_r843128395


##########
geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GetClusterConfigurationFunction.java:
##########
@@ -27,6 +27,7 @@
 
 public class GetClusterConfigurationFunction implements InternalFunction {
   private static final Logger logger = LogService.getLogger();
+  private static final long serialVersionUID = 6332908511113951823L;

Review Comment:
   Have you checked the logs to see if there is any warning like `InvalidClassException` complaining about incompatible serialVersionUID with the `serialVersionUID` added in the class, even if the test passes? I see your comments in the test about the LogCheckers. I assume LogCheckers will check the logs like `dunit_suspect-vm*.log`. But I don't see `withLogFile()` in when starting the locators. Without `withLogFile()`, the test won't generate locator logs in the file system. I am not sure whether the log file like `dunit_suspect-vm*.log` will collect everything from the locator logs, even though locator logs are not on the file system. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org