[GitHub] [superset] stephenLYZ commented on pull request #19881: feat(world-map): support color by metric or country column

[GitBox <gi...@apache.org>]

stephenLYZ commented on PR #19881:
URL: https://github.com/apache/superset/pull/19881#issuecomment-1113241645

   > Two random thoughts... and these can be separate tickets/PRs if we want to do either of them:
   > 
   > 1. This is the weird one: If you select to color the map by country, and deselect select "show bubbles," then you don't really need the Metric input (which is currently a required input). I thought for a second about making that input optional in that case... but in this configuration, the map is essentially useless, and doesn't tell you anything... so... whatever - fine as is. ¯\_(ツ)_/¯
   > 
   > 2a) You only actually need four colors to display a map. As a default, it might be nice to take advantage of that, if your mapping library happens to support the [four color theorem](https://en.wikipedia.org/wiki/Four_color_theorem) as a feature.
   > 
   > 2b) If we do take advantage of the four color theorem, it may get ugly with color consistency... so... I don't quite know what to do there.
   > 
   > 3. Also, with the color consistency thing... since a map might gobble up all the colors of a palette instantly, is there a good way to de-prioritize this chart (or others like it) it in the color assignment process?
   
   Thanks for these inputs! 
   1.  Yeah. The only scenario I can think of for categorical color is that the user wants to have a world map in a dashboard, and the colors of different countries correspond to the series in different charts, and that's it, so let's just focus on the metric 😂.
   2. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org