You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/07 16:59:50 UTC

[GitHub] [beam] damccorm opened a new pull request, #23067: Keep stale action from closing issues

damccorm opened a new pull request, #23067:
URL: https://github.com/apache/beam/pull/23067

   This config will keep stale bot from closing issues like it has recently started to do (https://github.com/actions/stale#days-before-issue-close for config option)
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm merged pull request #23067: Keep stale action from closing issues

Posted by GitBox <gi...@apache.org>.
damccorm merged PR #23067:
URL: https://github.com/apache/beam/pull/23067


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] aaltay commented on pull request #23067: Keep stale action from closing issues

Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #23067:
URL: https://github.com/apache/beam/pull/23067#issuecomment-1240945760

   Got it. Thank you for the detailed explanation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on pull request #23067: Keep stale action from closing issues

Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #23067:
URL: https://github.com/apache/beam/pull/23067#issuecomment-1240117378

   I'm not 100% sure, but I think there were 2 factors that kept it from happening until now:
   
   1) The default for the action is 60 days before marking stale and another 7 days before closing.
   2) The action batches its processing of issues and will only perform up to 30 actions (labeling or closing).
   
   I think those combined with us not running the bot very often (its only run daily) kept the bot from closing lots of issues since its been ~90 days since the migration to issues.
   
   FWIW, the core miss here was that this automation would automatically pick up issues without further action on our part.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on pull request #23067: Keep stale action from closing issues

Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #23067:
URL: https://github.com/apache/beam/pull/23067#issuecomment-1239653368

   R: @aaltay @kennknowles @Abacn (https://github.com/apache/beam/issues/22011#issuecomment-1239652250 for context)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #23067: Keep stale action from closing issues

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23067:
URL: https://github.com/apache/beam/pull/23067#issuecomment-1239787658

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] aaltay commented on pull request #23067: Keep stale action from closing issues

Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #23067:
URL: https://github.com/apache/beam/pull/23067#issuecomment-1239951895

   Thank you!
   
   Do we know why did this starting happening recently?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org