[GitHub] [kafka] dajac commented on a diff in pull request #13203: KAFKA-14048: Add new `__consumer_offsets` records from KIP-848

["dajac (via GitHub)" <gi...@apache.org>]

dajac commented on code in PR #13203:
URL: https://github.com/apache/kafka/pull/13203#discussion_r1098689954


##########
group-coordinator/src/main/resources/common/message/ConsumerGroupCurrentMemberAssignmentKey.json:
##########
@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// KIP-848 is in development. This schema is subject to non-backwards-compatible changes.
+{
+  "type": "data",
+  "name": "ConsumerGroupCurrentMemberAssignmentKey",
+  "validVersions": "8",

Review Comment:
   That's a very good question. For the `__consumer_offsets` records, the `version` is used as an unique identifier as well. I know... This is weird. My hope is to change this in the future, possibly before KIP-848 is released, but I will stick to this pattern for now so I can focus on the core implementation first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org