You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:54:44 UTC
[GitHub] [logging-log4j2] chenrui333 opened a new pull request #516: workflow: add stale PRs handling
chenrui333 opened a new pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516
It would be good to add some stale action to handle the stale PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers commented on pull request #516: workflow: add action to handle stale PRs
Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860839914
I'm not sure I agree with this. It seems too simplistic. Sometimes PRs are good but we are slow to apply them. Prior to every release I review all the PRs and close those I believe will never progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] chenrui333 edited a comment on pull request #516: workflow: add action to handle stale PRs
Posted by GitBox <gi...@apache.org>.
chenrui333 edited a comment on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860849535
yeah, you can add some labels of having stale bot ignoring the `in progress` PRs.
We actually have some more complicated flow in the homebrew side, https://github.com/Homebrew/.github/blob/master/.github/workflows/triage-issues.yml
But introducing this is just a simple step.
---
This is probably just me gauging the interest of stale action used in the community. 😄
Sorry for being too blunt of filing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #516: workflow: add action to handle stale PRs
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-861282409
Thanks so much for letting us know of this feature, much appreciated @chenrui333! Please don't get demotivated by the questions from the rest of us. This is a part of the deal when you are contributing to a project. Looking forward to your future PRs!
I agree with the comments of @rgoers and @jvz. Log4j crew handles PRs in a rather unorthodox way given the scarcity of development resources, hence I take the liberty of closing this PR without merging it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #516: workflow: add action to handle stale PRs
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-861097008
I think the best stale not setting would be notifying PR authors when they have merge conflicts to fix the issue. I don't think we get enough PRs to worry about closing old ones; we tend to work in batches anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] chenrui333 edited a comment on pull request #516: workflow: add action to handle stale PRs
Posted by GitBox <gi...@apache.org>.
chenrui333 edited a comment on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860849535
yeah, you can add some labels of having stale bot ignoring the `in progress` PRs.
We actually have some more complicated flow in the homebrew side, https://github.com/Homebrew/.github/blob/master/.github/workflows/triage-issues.yml
But introducing this is just a simple step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy closed pull request #516: workflow: add action to handle stale PRs
Posted by GitBox <gi...@apache.org>.
vy closed pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers edited a comment on pull request #516: workflow: add action to handle stale PRs
Posted by GitBox <gi...@apache.org>.
rgoers edited a comment on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860839914
I'm not sure I agree with this. It seems too simplistic. Sometimes PRs are good but we are slow to apply them. Prior to every release I review all the PRs and close those I believe will never progress. However, I'd like to see how other folks feel about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] chenrui333 commented on pull request #516: workflow: add action to handle stale PRs
Posted by GitBox <gi...@apache.org>.
chenrui333 commented on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860849535
yeah, you can add some labels of having stale bot ignoring the `in progress` PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] chenrui333 edited a comment on pull request #516: workflow: add action to handle stale PRs
Posted by GitBox <gi...@apache.org>.
chenrui333 edited a comment on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860849535
yeah, you can add some labels of having stale bot ignoring the `in progress` PRs.
We actually have some more complicated flow in the homebrew side, https://github.com/Homebrew/.github/blob/master/.github/workflows/triage-issues.yml
But introducing this is just a simple step.
---
This is probably just me gauging the interest of stale action used in the community. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz edited a comment on pull request #516: workflow: add action to handle stale PRs
Posted by GitBox <gi...@apache.org>.
jvz edited a comment on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-861097008
I think the best stale bot setting would be notifying PR authors when they have merge conflicts to fix the issue. I don't think we get enough PRs to worry about closing old ones; we tend to work in batches anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #516: workflow: add action to handle stale PRs
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #516:
URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-861443297
I agree with Ralph, staleness is not interesting here. The work I put in here very much sporadic so the age of a PR rarely matters,.what matters more are conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org