You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by squito <gi...@git.apache.org> on 2016/03/25 23:24:48 UTC
[GitHub] spark pull request: [SPARK-14168] Warn instead of Error on Managed...
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/11969
[SPARK-14168] Warn instead of Error on Managed Memory leak detection.
## What changes were proposed in this pull request?
The leak detection can be misleading, either when an iterator is not
read completely (eg. rdd.take()) or if there is a task failure.
Downgrade from error to warn, and reword slightly
## How was this patch tested?
Jenkins unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/squito/spark leak_msg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11969.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11969
----
commit 6a46ddbaa4441c58dfc36913b5825a1e773ec71a
Author: Imran Rashid <ir...@cloudera.com>
Date: 2016-03-25T22:19:27Z
[SPARK-14168] Warn instead of Error on Managed Memory leak detection.
The leak detection can be misleading, either when an iterator is not
read completely (eg. rdd.take()) or if there is a task failure.
Downgrade from error to warn, and reword slightly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14168] Warn instead of Error on Managed...
Posted by squito <gi...@git.apache.org>.
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/11969#issuecomment-201553654
cc @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14168] Warn instead of Error on Managed...
Posted by squito <gi...@git.apache.org>.
Github user squito closed the pull request at:
https://github.com/apache/spark/pull/11969
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14168] Warn instead of Error on Managed...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11969#issuecomment-202218949
**[Test build #2700 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2700/consoleFull)** for PR 11969 at commit [`6a46ddb`](https://github.com/apache/spark/commit/6a46ddbaa4441c58dfc36913b5825a1e773ec71a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14168] Warn instead of Error on Managed...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11969#issuecomment-202244631
**[Test build #2700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2700/consoleFull)** for PR 11969 at commit [`6a46ddb`](https://github.com/apache/spark/commit/6a46ddbaa4441c58dfc36913b5825a1e773ec71a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14168] Warn instead of Error on Managed...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11969#issuecomment-204079702
Let's close this PR in favor of #12052.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14168] Warn instead of Error on Managed...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11969#issuecomment-201551963
**[Test build #54226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54226/consoleFull)** for PR 11969 at commit [`6a46ddb`](https://github.com/apache/spark/commit/6a46ddbaa4441c58dfc36913b5825a1e773ec71a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14168] Warn instead of Error on Managed...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11969#discussion_r57823767
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -239,11 +239,12 @@ private[spark] class Executor(
val freedMemory = taskMemoryManager.cleanUpAllAllocatedMemory()
if (freedMemory > 0) {
- val errMsg = s"Managed memory leak detected; size = $freedMemory bytes, TID = $taskId"
+ val errMsg = s"Potential managed memory leak detected; " +
+ s"size = $freedMemory bytes, TID = $taskId. See SPARK-14168."
--- End diff --
what's the point of directing them to this minor issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14168] Warn instead of Error on Managed...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11969#issuecomment-201606181
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54226/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14168] Warn instead of Error on Managed...
Posted by squito <gi...@git.apache.org>.
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/11969#discussion_r58118427
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -239,11 +239,12 @@ private[spark] class Executor(
val freedMemory = taskMemoryManager.cleanUpAllAllocatedMemory()
if (freedMemory > 0) {
- val errMsg = s"Managed memory leak detected; size = $freedMemory bytes, TID = $taskId"
+ val errMsg = s"Potential managed memory leak detected; " +
+ s"size = $freedMemory bytes, TID = $taskId. See SPARK-14168."
--- End diff --
well, I was thinking that even its a WARN, a memory leak is still concerning to a user, so I wanted to explain to the user the cases where it was a known false-positive. But I couldn't come up with a short yet adequate thing to throw into the msg, so I figured the full explanation was contained in the jira.
Sorry I should have mentioned that in the first place, and just changing to warn is fine in any case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14168] Warn instead of Error on Managed...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11969#issuecomment-201606179
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14168] Warn instead of Error on Managed...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11969#issuecomment-201605730
**[Test build #54226 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54226/consoleFull)** for PR 11969 at commit [`6a46ddb`](https://github.com/apache/spark/commit/6a46ddbaa4441c58dfc36913b5825a1e773ec71a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org