You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/23 09:31:25 UTC
[GitHub] [shardingsphere] taojintianxia opened a new pull request, #21155: Refactor : refactor some constants and change the default option for PR template
taojintianxia opened a new pull request, #21155:
URL: https://github.com/apache/shardingsphere/pull/21155
Changes proposed in this pull request:
- refactor some constants
- change the default option for pre-check.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have triggered maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on pull request #21155: Refactor : refactor some constants and change the default option for PR template
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on PR #21155:
URL: https://github.com/apache/shardingsphere/pull/21155#issuecomment-1255991417
all checks passed in my forked repository
<img width="1430" alt="image" src="https://user-images.githubusercontent.com/4112856/191932196-1d082733-46a7-4d89-9235-fc5019dbdb82.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #21155: Refactor : refactor some constants and change the default option for PR template
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #21155:
URL: https://github.com/apache/shardingsphere/pull/21155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org