You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2013/03/07 16:51:45 UTC
Review Request: Notify transport when a socket closes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9802/
-----------------------------------------------------------
Review request for qpid, Cliff Jansen and Rafael Schloming.
Description
-------
The driver was missing code to notify the transport when a socket was closed (detected when a socket write or read is done).
This addresses bug proton-267.
https://issues.apache.org/jira/browse/proton-267
Diffs
-----
/proton/trunk/proton-c/src/posix/driver.c 1452846
/proton/trunk/proton-c/src/windows/driver.c 1452846
Diff: https://reviews.apache.org/r/9802/diff/
Testing
-------
Tested the posix implementation and verified the fix. Patched the windows driver using the diff from posix - verify it compiled on windows.
Thanks,
Kenneth Giusti
Re: Review Request: Notify transport when a socket closes.
Posted by Rafael Schloming <rh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9802/#review17613
-----------------------------------------------------------
Ship it!
Ship It!
- Rafael Schloming
On March 7, 2013, 3:51 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9802/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 3:51 p.m.)
>
>
> Review request for qpid, Cliff Jansen and Rafael Schloming.
>
>
> Description
> -------
>
> The driver was missing code to notify the transport when a socket was closed (detected when a socket write or read is done).
>
>
> This addresses bug proton-267.
> https://issues.apache.org/jira/browse/proton-267
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/src/posix/driver.c 1452846
> /proton/trunk/proton-c/src/windows/driver.c 1452846
>
> Diff: https://reviews.apache.org/r/9802/diff/
>
>
> Testing
> -------
>
> Tested the posix implementation and verified the fix. Patched the windows driver using the diff from posix - verify it compiled on windows.
>
>
> Thanks,
>
> Kenneth Giusti
>
>