You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2016/03/30 00:37:36 UTC
Fwd: [jira] [Resolved] (TOMEE-1762) Add a timeout to DataSource shutdown
Master got https://issues.apache.org/jira/browse/TOMEE-1761
Do we want to merge it with 1.7.x instead of using another config?
---------- Message transféré ----------
De : "Andy Gumbrecht (JIRA)" <ji...@apache.org>
Date : 30 mars 2016 00:29
Objet : [jira] [Resolved] (TOMEE-1762) Add a timeout to DataSource shutdown
À : <co...@openejb.apache.org>
Cc :
[
https://issues.apache.org/jira/browse/TOMEE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Gumbrecht resolved TOMEE-1762.
-----------------------------------
Resolution: Fixed
Added system property to TomEE 1.7.5-SNAPSHOT -
tomee.datasource.destroy.timeout.ms
The default if not specified is 1000
Min: 50
Max: 30000
> Add a timeout to DataSource shutdown
> ------------------------------------
>
> Key: TOMEE-1762
> URL: https://issues.apache.org/jira/browse/TOMEE-1762
> Project: TomEE
> Issue Type: Improvement
> Affects Versions: 1.7.4
> Reporter: Andy Gumbrecht
> Assignee: Andy Gumbrecht
> Priority: Minor
> Fix For: 1.7.5
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a timeout governed by the system property '
tomee.datasource.destroy.timeout.ms' that indicates how long a DataSource
destroy call will wait for the actual termination.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Fwd: [jira] [Resolved] (TOMEE-1762) Add a timeout to DataSource shutdown
Posted by Romain Manni-Bucau <rm...@gmail.com>.
well idea was to not have it by default (in particular no medium
duration timeout which can break apps flushing at that moment) so
wouldn't break anything since a choice. We can go further and activate
it by resource with another virtual property if desired but
datasources are not particular there. When I did it I was thinking to
AMQ as well where it can be useful.
Only issue I see is creating a thread which can leak by design but
while it is for diagnostic it is fine I guess. We can (should?) wire
it to an event (ResourceDestructionTimeoutEvent? do we want the
creation one?) to be able to plug an alert in such a case.
Romain Manni-Bucau
@rmannibucau | Blog | Github | LinkedIn | Tomitriber
2016-03-30 22:30 GMT+02:00 Andy <an...@gmx.de>:
> Sure, just took the smallest step to solve the known issue but did think
> that the whole resource destroy block could work the same way - Just was not
> sure if 'all' the resource destroy methods could be called safely from a
> thread.
>
>
> On 30/03/2016 00:37, Romain Manni-Bucau wrote:
>>
>> Master got https://issues.apache.org/jira/browse/TOMEE-1761
>>
>> Do we want to merge it with 1.7.x instead of using another config?
>> ---------- Message transféré ----------
>> De : "Andy Gumbrecht (JIRA)" <ji...@apache.org>
>> Date : 30 mars 2016 00:29
>> Objet : [jira] [Resolved] (TOMEE-1762) Add a timeout to DataSource
>> shutdown
>> À : <co...@openejb.apache.org>
>> Cc :
>>
>>
>> [
>>
>> https://issues.apache.org/jira/browse/TOMEE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Andy Gumbrecht resolved TOMEE-1762.
>> -----------------------------------
>> Resolution: Fixed
>>
>> Added system property to TomEE 1.7.5-SNAPSHOT -
>> tomee.datasource.destroy.timeout.ms
>> The default if not specified is 1000
>> Min: 50
>> Max: 30000
>>
>>> Add a timeout to DataSource shutdown
>>> ------------------------------------
>>>
>>> Key: TOMEE-1762
>>> URL: https://issues.apache.org/jira/browse/TOMEE-1762
>>> Project: TomEE
>>> Issue Type: Improvement
>>> Affects Versions: 1.7.4
>>> Reporter: Andy Gumbrecht
>>> Assignee: Andy Gumbrecht
>>> Priority: Minor
>>> Fix For: 1.7.5
>>>
>>> Original Estimate: 2h
>>> Remaining Estimate: 2h
>>>
>>> Add a timeout governed by the system property '
>>
>> tomee.datasource.destroy.timeout.ms' that indicates how long a DataSource
>> destroy call will wait for the actual termination.
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
>
> --
> Andy Gumbrecht
> https://twitter.com/AndyGeeDe
>
Re: Fwd: [jira] [Resolved] (TOMEE-1762) Add a timeout to DataSource
shutdown
Posted by Andy <an...@gmx.de>.
Sure, just took the smallest step to solve the known issue but did think
that the whole resource destroy block could work the same way - Just was
not sure if 'all' the resource destroy methods could be called safely
from a thread.
On 30/03/2016 00:37, Romain Manni-Bucau wrote:
> Master got https://issues.apache.org/jira/browse/TOMEE-1761
>
> Do we want to merge it with 1.7.x instead of using another config?
> ---------- Message transféré ----------
> De : "Andy Gumbrecht (JIRA)" <ji...@apache.org>
> Date : 30 mars 2016 00:29
> Objet : [jira] [Resolved] (TOMEE-1762) Add a timeout to DataSource shutdown
> À : <co...@openejb.apache.org>
> Cc :
>
>
> [
> https://issues.apache.org/jira/browse/TOMEE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Andy Gumbrecht resolved TOMEE-1762.
> -----------------------------------
> Resolution: Fixed
>
> Added system property to TomEE 1.7.5-SNAPSHOT -
> tomee.datasource.destroy.timeout.ms
> The default if not specified is 1000
> Min: 50
> Max: 30000
>
>> Add a timeout to DataSource shutdown
>> ------------------------------------
>>
>> Key: TOMEE-1762
>> URL: https://issues.apache.org/jira/browse/TOMEE-1762
>> Project: TomEE
>> Issue Type: Improvement
>> Affects Versions: 1.7.4
>> Reporter: Andy Gumbrecht
>> Assignee: Andy Gumbrecht
>> Priority: Minor
>> Fix For: 1.7.5
>>
>> Original Estimate: 2h
>> Remaining Estimate: 2h
>>
>> Add a timeout governed by the system property '
> tomee.datasource.destroy.timeout.ms' that indicates how long a DataSource
> destroy call will wait for the actual termination.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
--
Andy Gumbrecht
https://twitter.com/AndyGeeDe