You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by js...@apache.org on 2004/02/12 02:41:58 UTC
cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/gui/tree JMeterTreeModel.java
jsalvata 2004/02/11 17:41:58
Modified: src/core/org/apache/jmeter/gui/tree JMeterTreeModel.java
Log:
Fix overwriting of existing elements during proxy recording.
Changes GUI behaviour: new elements are initialized blank, instead
of with the values of the last edited element of the same type.
PR: 24704, 25166
Revision Changes Path
1.22 +5 -6 jakarta-jmeter/src/core/org/apache/jmeter/gui/tree/JMeterTreeModel.java
Index: JMeterTreeModel.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/gui/tree/JMeterTreeModel.java,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- JMeterTreeModel.java 1 Dec 2003 01:01:52 -0000 1.21
+++ JMeterTreeModel.java 12 Feb 2004 01:41:58 -0000 1.22
@@ -65,8 +65,6 @@
import org.apache.jmeter.control.gui.TestPlanGui;
import org.apache.jmeter.control.gui.WorkBenchGui;
import org.apache.jmeter.exceptions.IllegalUserActionException;
-import org.apache.jmeter.gui.GuiPackage;
-import org.apache.jmeter.gui.JMeterGUIComponent;
import org.apache.jmeter.testelement.TestElement;
import org.apache.jmeter.testelement.TestPlan;
import org.apache.jmeter.testelement.WorkBench;
@@ -165,9 +163,10 @@
TestElement.GUI_CLASS,
NameUpdater.getCurrentName(
component.getPropertyAsString(TestElement.GUI_CLASS)));
- JMeterGUIComponent guicomp = GuiPackage.getInstance().getGui(component);
- guicomp.configure(component);
- guicomp.modifyTestElement(component);
+// Commenting these three lines fixed bug#24704 and bug#25166. TODO: remove them.
+// JMeterGUIComponent guicomp = GuiPackage.getInstance().getGui(component);
+// guicomp.configure(component);
+// guicomp.modifyTestElement(component);
JMeterTreeNode newNode =
new JMeterTreeNode((TestElement) component, this);
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org