[jira] [Commented] (FLINK-15791) Don't use ForkJoinPool#commonPool() for executing asynchronous operations in Fabric8FlinkKubeClient

["Yang Wang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026474#comment-17026474 ] 

Yang Wang commented on FLINK-15791:
-----------------------------------

I think your concern is on point. I will fix it.

> Don't use ForkJoinPool#commonPool() for executing asynchronous operations in Fabric8FlinkKubeClient
> ---------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-15791
>                 URL: https://issues.apache.org/jira/browse/FLINK-15791
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Deployment / Kubernetes
>    Affects Versions: 1.10.0
>            Reporter: Till Rohrmann
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.11.0, 1.10.1
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We should not use the {{ForkJoinPool#commonPool()}} in order to run asynchronous operations in the {{Fabric8FlinkKubeClient}} as it is done [here|https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L315]. Since we don't know which other component is using this pool, it can be quite dangerous to use it as there might be congestion.
> Instead, I propose to provide an explicit I/O {{Executor}} which is used for running asynchronous operations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)